refactor: simplify Dockerfile.vllm, enable local-dev for all frameworks

.devcontainer/README.md

@@ -91,13 +91,21 @@ Follow these steps to get your NVIDIA Dynamo development environment up and runn
 
 ### Step 1: Build the Development Container Image
 
-Build `dynamo:latest-vllm` from scratch from the source:
+Build `dynamo:latest-vllm-local-dev` from scratch from the source:
 
 ```bash
-./container/build.sh --target dev --framework VLLM
+# Single command approach (recommended)
+./container/build.sh --framework VLLM --target local-dev
+# Creates both dynamo:latest-vllm and dynamo:latest-vllm-local-dev
+
+# Alternatively, you can build a development container then local-dev
+./container/build.sh --framework VLLM
+# Now you have a development image dynamo:latest-vllm
+./container/build.sh --dev-image dynamo:latest-vllm --framework VLLM
+# Now you have a local-dev image dynamo:latest-vllm-local-dev
 ```
 
-The container will be built and give certain file permissions to your local uid and gid.
+The local-dev image will give you local user permissions matching your host user and includes extra developer utilities (debugging tools, text editors, system monitors, etc.).
 
 ### Step 2: Install Dev Containers Extension
 
@@ -235,30 +243,6 @@ cp .devcontainer/devcontainer.json .devcontainer/jensen_dev/devcontainer.json
 
 Common customizations include additional mounts, environment variables, IDE extensions, and build arguments. When you open a new Dev Container, you can pick from any of the `.devcontainer/<path>/devcontainer.json` files available.
 
-### SGLANG Custom devcontainer.json Configuration (EXPERIMENTAL)
-
-This is experimental. Please update/fix if you encounter problems. For sglang Dev Container, you first need to build `dynamo:latest-sglang-local-dev` image like this (wait about half an hour):
-
-```bash
-./container/build.sh --framework SGLANG --target local-dev
-```
-
-Then, make a copy of the `devcontainer.json file` to a directory of your choice. For this example, we'll just call it `sglang`:
-
-```bash
-mkdir .devcontainer/sglang/
-cp -a .devcontainer/devcontainer.json .devcontainer/sglang/
-```
-
-Afterwards, edit your `.devcontainer/sglang/devcontainer.json` so that the name and image correspond to SGLANG. Example:
-```json
-    "name": "[sglang] This is my amazing custom Dev Container Development",
-    ...
-    "image": "dynamo:latest-sglang-local-dev",
-```
-
-Now, go to **Dev Containers: Open Folder in Container** and select `[sglang] This is my amazing custom Dev Container Development`. The post-create.sh script should be running.
-
 
 ### SSH Keys for Git Operations
 
@@ -372,13 +356,15 @@ If you see errors like "container is not running" or "An error occurred setting
 
 **Common Causes and Solutions:**
 
-1. **Missing base image:**
+1. **Missing a local-dev image:**
    ```bash
-   # Check if the required image exists
+   # Check if the required local-dev image exists
    docker images | grep dynamo
 
-   # If missing, build the dev image first
-   ./container/build.sh --target local-dev
+   # If missing, build the dev image first, then build local-dev
+   ./container/build.sh --framework vllm
+   ./container/build.sh --dev-image dynamo:latest-vllm --framework vllm
+   # Output: dynamo:latest-vllm-local-dev
    ```
 
 2. **Container startup failure:**

container/Dockerfile.local_dev

@@ -0,0 +1,125 @@
+# syntax=docker/dockerfile:1.10.0
+# SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+
+# This Dockerfile creates a local development environment for Dev Container plug-in use.
+# It takes a BASE image (typically the dev target) and adds local-dev specific configurations
+# including additional developer utilities and tools.
+#
+# Usage:
+# - Dev Container IDE Extension: Use directly with VS Code/Cursor Dev Container extension
+# - Command line: run.sh --image <local-dev-image> --mount-workspace ...
+#   where the ubuntu user inside the container is mapped to your local user login
+
+ARG DEV_BASE=""
+FROM ${DEV_BASE} AS local-dev
+
+# Don't want ubuntu to be editable, just change uid and gid.
+ENV USERNAME=ubuntu
+ARG USER_UID
+ARG USER_GID
+ARG WORKSPACE_DIR=/workspace
+
+ARG ARCH
+
+# Update package lists and install developer utilities. Some of these may exist in the base image,
+# but to ensure consistency across all dev images, we explicitly list all required dev tools here.
+RUN apt-get update && apt-get install -y \
+    # Development utilities
+    curl wget git vim nano \
+    # System utilities
+    htop nvtop tmux screen \
+    # Network utilities
+    net-tools iproute2 iputils-ping \
+    # Archive utilities
+    zip unzip rsync \
+    # Build tools
+    build-essential cmake autoconf automake libtool \
+    # Debug and analysis tools
+    gdb valgrind strace ltrace \
+    # Text processing
+    jq yq grep sed \
+    # File utilities
+    tree fd-find ripgrep \
+    # Shell utilities
+    zsh fish bash-completion
+
+# https://code.visualstudio.com/remote/advancedcontainers/add-nonroot-user
+# Configure user with sudo access for Dev Container workflows
+RUN apt-get install -y sudo gnupg2 gnupg1 \
+    && echo "$USERNAME ALL=(root) NOPASSWD:ALL" > /etc/sudoers.d/$USERNAME \
+    && chmod 0440 /etc/sudoers.d/$USERNAME \
+    && mkdir -p /home/$USERNAME \
+    && groupmod -g $USER_GID $USERNAME \
+    && usermod -u $USER_UID -g $USER_GID $USERNAME \
+    && chown -R $USERNAME:$USERNAME /home/$USERNAME \
+    && chsh -s /bin/bash $USERNAME
+
+# Install awk separately with fault tolerance
+# awk is a virtual package with multiple implementations (gawk, mawk, original-awk).
+# Separated because TensorRT-LLM builds failed on awk package conflicts.
+# This prevents main package installation failures due to awk availability issues.
+RUN (apt-get install -y gawk || \
+     apt-get install -y mawk || \
+     apt-get install -y original-awk || \
+     echo "Warning: Could not install any awk implementation") && \
+    (which awk && echo "awk successfully installed: $(which awk)" || echo "awk not available")
+
+# Add NVIDIA devtools repository and install development tools
+RUN wget -qO - https://developer.download.nvidia.com/devtools/repos/ubuntu2404/${ARCH}/nvidia.pub | gpg --dearmor -o /etc/apt/keyrings/nvidia-devtools.gpg && \
+    echo "deb [signed-by=/etc/apt/keyrings/nvidia-devtools.gpg] https://developer.download.nvidia.com/devtools/repos/ubuntu2404/${ARCH} /" | tee /etc/apt/sources.list.d/nvidia-devtools.list && \
+    apt-get update && \
+    apt-get install -y nsight-systems-2025.5.1
+
+# Clean up package lists at the end
+RUN rm -rf /var/lib/apt/lists/*
+
+# Set workspace directory variable
+ENV WORKSPACE_DIR=${WORKSPACE_DIR}
+
+# Development environment variables for the local-dev target
+# Path configuration notes:
+# - DYNAMO_HOME: Main project directory (workspace mount point)
+# - CARGO_TARGET_DIR: Build artifacts in workspace/target for persistence
+# - CARGO_HOME: Must be in $HOME/.cargo (not workspace) because:
+#               * Workspace gets mounted to different paths where cargo binaries may not exist
+#               * Contains critical cargo binaries and registry that need consistent paths
+# - RUSTUP_HOME: Must be in $HOME/.rustup (not workspace) because:
+#                * Contains rust toolchain binaries that must be at expected system paths
+#                * Workspace mount point would break rustup's toolchain resolution
+# - PATH: Includes cargo binaries for rust tool access
+ENV DYNAMO_HOME=${WORKSPACE_DIR}
+ENV CARGO_TARGET_DIR=${WORKSPACE_DIR}/target
+ENV CARGO_HOME=${HOME}/.cargo
+ENV RUSTUP_HOME=${HOME}/.rustup
+ENV PATH=${CARGO_HOME}/bin:$PATH
+
+# Copy Rust toolchain from system directories to user home directories with proper ownership
+RUN rsync -a --chown=$USER_UID:$USER_GID /usr/local/rustup/ $RUSTUP_HOME/
+
+RUN rsync -a --chown=$USER_UID:$USER_GID /usr/local/cargo/ $CARGO_HOME/
+
+# Copy virtual environment with proper ownership using rsync instead of chown.
+# Why rsync instead of chown -R:
+# chown -R is extremely slow in Docker containers, especially on large directory trees
+# like Python virtual environments with thousands of files. This is a well-documented
+# Docker performance issue. rsync --chown is 3-4x faster as it sets ownership during copy.
+RUN rsync -a --chown=$USER_UID:$USER_GID ${VIRTUAL_ENV}/ /tmp/venv-temp/ && \
+    rm -rf ${VIRTUAL_ENV} && \
+    mv /tmp/venv-temp ${VIRTUAL_ENV}
+
+# At this point, we are executing as the ubuntu user
+USER $USERNAME
+ENV HOME=/home/$USERNAME
+WORKDIR $HOME
+
+# https://code.visualstudio.com/remote/advancedcontainers/persist-bash-history
+RUN SNIPPET="export PROMPT_COMMAND='history -a' && export HISTFILE=$HOME/.commandhistory/.bash_history" \
+    && mkdir -p $HOME/.commandhistory \
+    && touch $HOME/.commandhistory/.bash_history \
+    && echo "$SNIPPET" >> "$HOME/.bashrc"
+
+RUN mkdir -p /home/$USERNAME/.cache/
+
+ENTRYPOINT ["/opt/nvidia/nvidia_entrypoint.sh"]
+CMD []

container/Dockerfile.vllm

@@ -289,125 +289,6 @@ RUN --mount=type=bind,source=./container/launch_message.txt,target=/workspace/la
 ENTRYPOINT ["/opt/nvidia/nvidia_entrypoint.sh"]
 CMD []
 
-#######################################################################
-########## Development (Dev Container only) ###########################
-#######################################################################
-#
-# This stage is for Dev Container plug-in use only.
-# It provides a local development environment with extra tools and dependencies
-# not present in the base runtime image.
-
-FROM runtime AS local-dev
-
-# Don't want ubuntu to be editable, just change uid and gid.
-ENV USERNAME=ubuntu
-ARG USER_UID
-ARG USER_GID
-ARG WORKSPACE_DIR=/workspace
-
-# Install utilities as root
-RUN apt-get update -y && \
-    apt-get install -y --no-install-recommends  \
-    # Install utilities
-    nvtop \
-    wget \
-    tmux \
-    vim \
-    git \
-    openssh-client \
-    iproute2 \
-    rsync \
-    zip \
-    unzip \
-    htop \
-    # Build Dependencies
-    autoconf \
-    automake \
-    cmake \
-    libtool \
-    meson \
-    net-tools \
-    pybind11-dev \
-    # Rust build dependencies
-    clang \
-    libclang-dev \
-    protobuf-compiler && \
-    rm -rf /var/lib/apt/lists/*
-
-
-ARG ARCH
-RUN wget -qO - https://developer.download.nvidia.com/devtools/repos/ubuntu2404/${ARCH}/nvidia.pub | gpg --dearmor -o /etc/apt/keyrings/nvidia-devtools.gpg && \
-    echo "deb [signed-by=/etc/apt/keyrings/nvidia-devtools.gpg] https://developer.download.nvidia.com/devtools/repos/ubuntu2404/${ARCH} /" | tee /etc/apt/sources.list.d/nvidia-devtools.list && \
-    apt-get update && \
-    apt-get install -y nsight-systems-2025.5.1 && \
-    rm -rf /var/lib/apt/lists/*
-
-COPY --from=runtime /usr/local/bin /usr/local/bin
-
-# https://code.visualstudio.com/remote/advancedcontainers/add-nonroot-user
-# Will use the default ubuntu user, but give sudo access
-# Needed so files permissions aren't set to root ownership when writing from inside container
-RUN apt-get update && apt-get install -y sudo gnupg2 gnupg1 \
-    && echo "$USERNAME ALL=(root) NOPASSWD:ALL" > /etc/sudoers.d/$USERNAME \
-    && chmod 0440 /etc/sudoers.d/$USERNAME \
-    && mkdir -p /home/$USERNAME \
-    && groupmod -g $USER_GID $USERNAME \
-    && usermod -u $USER_UID -g $USER_GID $USERNAME \
-    && chown -R $USERNAME:$USERNAME /home/$USERNAME \
-    && rm -rf /var/lib/apt/lists/* \
-    && chsh -s /bin/bash $USERNAME
-
-# At this point, we are executing as the ubuntu user
-USER $USERNAME
-ENV HOME=/home/$USERNAME
-WORKDIR $HOME
-
-# Set workspace directory variable
-ENV WORKSPACE_DIR=${WORKSPACE_DIR}
-
-# Development environment variables for the dev target
-# Path configuration notes:
-# - DYNAMO_HOME: Main project directory (workspace mount point)
-# - CARGO_TARGET_DIR: Build artifacts in workspace/target for persistence
-# - CARGO_HOME: Must be in $HOME/.cargo (not workspace) because:
-#               * Workspace gets mounted to different paths where cargo binaries may not exist
-#               * Contains critical cargo binaries and registry that need consistent paths
-# - RUSTUP_HOME: Must be in $HOME/.rustup (not workspace) because:
-#                * Contains rust toolchain binaries that must be at expected system paths
-#                * Workspace mount point would break rustup's toolchain resolution
-# - PATH: Includes cargo binaries for rust tool access
-ENV DYNAMO_HOME=${WORKSPACE_DIR}
-ENV CARGO_TARGET_DIR=${WORKSPACE_DIR}/target
-ENV CARGO_HOME=${HOME}/.cargo
-ENV RUSTUP_HOME=${HOME}/.rustup
-ENV PATH=${CARGO_HOME}/bin:$PATH
-
-COPY --from=dynamo_base --chown=$USER_UID:$USER_GID /usr/local/rustup $RUSTUP_HOME
-COPY --from=dynamo_base --chown=$USER_UID:$USER_GID /usr/local/cargo $CARGO_HOME
-
-# This is a slow operation (~40s on my cpu)
-# Much better than chown -R $USERNAME:$USERNAME /opt/dynamo/venv (~10min on my cpu)
-COPY --from=runtime --chown=$USER_UID:$USER_GID ${VIRTUAL_ENV} ${VIRTUAL_ENV}
-
-# so we can use maturin develop
-RUN uv pip install maturin[patchelf]
-
-# Make sure to sync this with the one specified on README.md.
-# This is a generic PYTHONPATH which works for all the frameworks, so some paths may not be relevant for this particular framework.
-ENV PYTHONPATH=${WORKSPACE_DIR}/components/metrics/src:${WORKSPACE_DIR}/components/frontend/src:${WORKSPACE_DIR}/components/planner/src:${WORKSPACE_DIR}/components/backends/mocker/src:${WORKSPACE_DIR}/components/backends/trtllm/src:${WORKSPACE_DIR}/components/backends/vllm/src:${WORKSPACE_DIR}/components/backends/sglang/src:${WORKSPACE_DIR}/components/backends/llama_cpp/src
-
-# https://code.visualstudio.com/remote/advancedcontainers/persist-bash-history
-RUN SNIPPET="export PROMPT_COMMAND='history -a' && export HISTFILE=$HOME/.commandhistory/.bash_history" \
-    && mkdir -p $HOME/.commandhistory \
-    && touch $HOME/.commandhistory/.bash_history \
-    && echo "$SNIPPET" >> "$HOME/.bashrc"
-
-RUN mkdir -p /home/$USERNAME/.cache/
-
-ENTRYPOINT ["/opt/nvidia/nvidia_entrypoint.sh"]
-CMD []
-
-
 ###########################################################
 ########## Development (run.sh, runs as root user) ########
 ###########################################################