Metrics Provider DEP #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whoisj
force-pushed
the
whoisj/metric-provider
branch
7 times, most recently
from
5546fbe to
583936a
Compare
|
Looks good to me. Can you also mention gauges (which we do use today)? |
keivenchang
approved these changes
Aug 4, 2025
whoisj
force-pushed
the
whoisj/metric-provider
branch
from
583936a to
fb53dec
Compare
whoisj
force-pushed
the
whoisj/metric-provider
branch
from
fb53dec to
2e7b20d
Compare
nnshah1
requested changes
Aug 13, 2025
There was a problem hiding this comment.
I think the primary question is this something within scope of dynamo - to provide a library for use outside of dynamo -
Before further discussion on technical details - I want to understand scope and if there is pull from other projects (i.e. is NIXL looking for such a library?) - currently each of the backends and libraries (nats, vllm, sglang, etc.) - have their own internal stats / metrics tracking and we look to expose them to dynamo via dynamo apis -
@harryskim for viz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a metrics provider DEP: