Skip to content

Conversation

robpats
Copy link

@robpats robpats commented Sep 7, 2025

What do these changes do?

Currently it is not possible to get the real progress of downloading data. The closest thing is `StreamReader.total_bytes, but it could be the number of bytes of decompressed data. This pull request addresses this.

Are there changes in behavior for the user?

A new property StreamReader.total_raw_bytes can be used by the user.

Is it a substantial burden for the maintainers to support this?

Related issue number

#11432

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES/ folder

Copy link

codecov bot commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.72%. Comparing base (8767e9e) to head (b8fa534).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11483      +/-   ##
==========================================
- Coverage   98.75%   98.72%   -0.03%     
==========================================
  Files         129      129              
  Lines       43418    43450      +32     
  Branches     2325     2326       +1     
==========================================
+ Hits        42879    42898      +19     
- Misses        384      394      +10     
- Partials      155      158       +3     
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (-0.03%) ⬇️
OS-Linux 98.35% <100.00%> (-0.03%) ⬇️
OS-Windows 96.70% <100.00%> (-0.10%) ⬇️
OS-macOS 97.42% <100.00%> (-0.27%) ⬇️
Py-3.10.11 96.17% <100.00%> (-1.17%) ⬇️
Py-3.10.18 97.72% <100.00%> (-0.01%) ⬇️
Py-3.11.13 97.92% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.36% <100.00%> (-0.27%) ⬇️
Py-3.12.11 98.02% <100.00%> (+<0.01%) ⬆️
Py-3.13.7 98.04% <100.00%> (-0.24%) ⬇️
Py-3.9.13 ?
Py-3.9.23 97.61% <100.00%> (+<0.01%) ⬆️
Py-pypy3.9.19-7.3.16 ?
VM-macos 97.42% <100.00%> (-0.27%) ⬇️
VM-ubuntu 98.35% <100.00%> (-0.03%) ⬇️
VM-windows 96.70% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 7, 2025

CodSpeed Performance Report

Merging #11483 will not alter performance

Comparing robpats:patch (bff2837) with master (8767e9e)

Summary

✅ 59 untouched benchmarks

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 7, 2025
@robpats robpats marked this pull request as ready for review September 7, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant