Fix precommit config and fix workflow. #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ubuntu version as 20.04 is deprecated and not available anymore for github actions.
Contributor
|
Looks good; thanks for the updates. |
alexander-sung
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the pre-commit-config to replace pylint and isort with ruff.
It also fixes the CI workflow config by using ubuntu-latest as 20.04 is deprecated and not avaialbel anymore for github actions.
The reason for using ruff where version incompatibilities between Python 3.12 and the previously used version of pylint. It was also not possible to update pylint to a newer version as this would break compatibility with Python 3.8 which we still have, also this debatable as 3.8 is also not supported, anymore.
Additionally, using ruff has the advantage of being faster than pylint, which is the reasong that pylint documentation does not recommend to use it in the pre-commit stage.