Skip to content

Allow isExpressionValueUsed() to skip awaits #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow isExpressionValueUsed() to skip awaits #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d45523
Allow isExpressionValueUsed() to skip awaits
SLaks Jul 10, 2020
23afa2d
Fix lint error
SLaks Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions util/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,10 +832,20 @@ export function getDeclarationOfBindingElement(node: ts.BindingElement): ts.Vari
return parent;
}

export function isExpressionValueUsed(node: ts.Expression): boolean {
export const enum ExpressionValueUsedOptions {
None = 0,
/** Only return true for an await expression if its resullt is used. */
IgnoreAwaits = 1,
}

export function isExpressionValueUsed(node: ts.Expression, options: ExpressionValueUsedOptions = ExpressionValueUsedOptions.None): boolean {
while (true) {
const parent = node.parent!;
switch (parent.kind) {
case ts.SyntaxKind.AwaitExpression:
if (options & ExpressionValueUsedOptions.IgnoreAwaits)
break; // Check whether the await is used.
return true;
case ts.SyntaxKind.CallExpression:
case ts.SyntaxKind.NewExpression:
case ts.SyntaxKind.ElementAccessExpression:
Expand All @@ -860,7 +870,6 @@ export function isExpressionValueUsed(node: ts.Expression): boolean {
case ts.SyntaxKind.TemplateSpan:
case ts.SyntaxKind.ExpressionWithTypeArguments:
case ts.SyntaxKind.TypeOfExpression:
case ts.SyntaxKind.AwaitExpression:
case ts.SyntaxKind.YieldExpression:
case ts.SyntaxKind.LiteralType:
case ts.SyntaxKind.JsxAttributes:
Expand Down