Remove focused property from input props #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the
focused
boolean may have been included in the properties returned fromgetInputProps
by mistake. It looks like this piece of internal state is used to determine whether or not to include thevalue
attribute in the input props based on the current focus. Includingfocused
as a boolean in the input props results in users spreading it on to the input, which triggers the following React warning:This change removes it from the input props (but not from the values passed to the
render
prop). You could also stringify the value as an alternative (which will silence the warning), but I don't believe it should be there to begin with (correct me if I'm wrong).