fix(#43): Load all schemas before validating them #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainjreid
commented
Jun 24, 2022
| } | ||
|
|
||
| function compileSchema(file: string): AnyValidateFunction | undefined { | ||
| const sch = openFile(file, `schema ${file}`) |
There was a problem hiding this comment.
This line could be removed if the schema name were set to the filename by default, and ignoring the IDs, would that be helpful to add to this PR?
|
I've locked the version of TypeScript in the package file to prevent the build failures 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR ensures that all of the schemas passed through the CLI are loaded before they're validated, allowing schemas to cross reference each other without having to be loaded in a given order 👍