chore: rename factoryAddress to factory #2302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Richard-Dang
requested review from
0xfourzerofour,
AlvaroLuken,
Dan-Nolan,
SahilAujla,
andysim3d,
avarobinson,
blakecduncan,
dancoombs,
florrdv,
jakehobbs,
linnall,
niveda-krish and
thebrianchen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the parameter naming for factory addresses across multiple smart account implementations, renaming factoryAddress to factory for consistency and alignment with the existing return structure where factory arguments use the shorter name.
Key Changes:
- Renamed
factoryAddressparameter tofactoryacross all account creation functions - Updated all references to use the new parameter name consistently
- Modified test assertions to reflect the parameter name change
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/smart-accounts/src/ma-v2/decorators/deferralActions.test.ts | Updated test assertion to use factory instead of factoryAddress |
| packages/smart-accounts/src/ma-v2/accounts/account.ts | Renamed factoryAddress parameter to factory in type definitions and function signature for Modular Account V2 |
| packages/smart-accounts/src/ma-v1/accounts/multi-owner-account.ts | Renamed factoryAddress parameter to factory in Multi-Owner Modular Account V1 implementation |
| packages/smart-accounts/src/light-account/accounts/multi-owner-account.ts | Renamed factoryAddress parameter to factory in Multi-Owner Light Account implementation |
| packages/smart-accounts/src/light-account/accounts/account.ts | Renamed factoryAddress parameter to factory and removed unnecessary formatting in Light Account implementation |
| docs-site | Updated documentation submodule reference |
🌿 Documentation Preview
|
Richard-Dang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/alchemy-fa-strike-force-7/issue/ALC-382/rename-factoryaddress-to-factory
PR-Codex overview
This PR primarily focuses on renaming the
factoryAddressproperty tofactoryacross multiple files in thepackages/smart-accountsdirectory, as well as enhancements to the build skipping logic in thescripts/vercel-ignore-build.sh.Detailed summary
factoryAddresstofactoryin:packages/smart-accounts/src/ma-v2/decorators/deferralActions.test.tspackages/smart-accounts/src/ma-v2/accounts/account.tspackages/smart-accounts/src/light-account/accounts/multi-owner-account.tspackages/smart-accounts/src/ma-v1/accounts/multi-owner-account.tspackages/smart-accounts/src/light-account/accounts/account.tsscripts/vercel-ignore-build.shfor better branch ancestry checks.