Before saying goodbye and stopping, check first whether this skill is currently playing audio. #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
If users say "Alexa, stop" when AudioPlayer was last used by a custom skill, that skill will receive an AMAZON.StopIntent request, even if audio is not playing any more.
Before giving a goodbye message, a custom skill needs to check whether it is currently playing audio.
Description of changes:
When audio is currently playing,
context
in the intent request looks like:Here's what
context
looks like if playback is already stopped:I have added checks for StopIntent and PauseIntent for both single-stream and multiple-stream, with unit tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.