Skip to content

routeNotificationForFirebase checks #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

routeNotificationForFirebase checks #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc232c5
Throw exception when routeNotificationForFirebase is not defined
dblazeski Apr 4, 2020
68e46fc
devices expects an array and fails silently if string provided
dblazeski Apr 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/FirebaseChannel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,18 @@ public function send($notifiable, Notification $notification)
{
$devices = $notifiable->routeNotificationFor('firebase');

if (!method_exists($notifiable, 'routeNotificationForFirebase')) {
throw new Exception('Firebase notification method "routeNotificationForFirebase" is not implemented but was called for ' . $notifiable->getTable());
}

if (empty($devices)) {
return;
}

if (!is_array($devices)) {
throw new Exception('Firebase notification method "routeNotificationForFirebase" in ' . $notifiable->getTable() . ' should return an array');
}

$firebase = $notification->toFirebase($notifiable);

try {
Expand Down