-
Notifications
You must be signed in to change notification settings - Fork 171
MAGE-1109: Add Batching Optimizer feature #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAGE-1109: Add Batching Optimizer feature #1797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love where this is going. I know this is WIP - just a couple of small observations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just fantastic work @damcou !! 🙌
I do see some issues if you wouldn't mind taking a look and had a few suggestions.
I also think we should add some language that says something along the lines that these numbers are estimates only and that indexing activity should be monitored after making changes to ensure batches are not exceeding the recommended size of 10 MB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a POC for the issue you mentioned - if you think this can work then we could do something for margin as well.
Also noted one issue on the division by zero check.
Additional comments in Jira.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chebyshev for the win! 😆
Looking great. Let's go! 🚀
This PR contains the Batching Optimizer CLI command which include the following process:
store_id
argument).simple
,virtual
,downloadable
,giftcard
) and "complex products" (configurable
,bundle
,grouped
) in the catalog. (for example, a sample of 20 products from a catalog composed of 40% of simple products and 60% of complex products will have 8 simple products and 12 complex products).