Adds timing for the individual weight sync events #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnoukhov
approved these changes
Sep 25, 2025
Comment on lines
+2189
to
+2197
| # Calculate distribution statistics | ||
| sync_time_stats = { | ||
| "time/weight_sync": timer.duration, | ||
| "time/weight_sync_mean": np.mean(actor_sync_times), | ||
| "time/weight_sync_min": np.min(actor_sync_times), | ||
| "time/weight_sync_max": np.max(actor_sync_times), | ||
| "time/weight_sync_median": np.median(actor_sync_times), | ||
| } | ||
|
|
There was a problem hiding this comment.
you could consider keeping the actual list and logging a histogram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only timed the entire weight sync event, and not the individual ones. This adds timing for each one.
To enable this, we now record timing of each future in
ray_get_with_progress.