-
Notifications
You must be signed in to change notification settings - Fork 443
Update Safety Evals #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Safety Evals #850
Conversation
If we are consolidating to oe-eval, is it possible to just remove the existing safety eval code and instead rely on the pre-existing oe-eval code? I understand the want to not touch the old logic but I think its cleaner if we just have this one single oe-eval setup, and not do something special for safety evals. And maybe you can add a SAFETY_EVAL preset like this: https://github.com/allenai/open-instruct/blob/main/scripts/eval/oe-eval.sh#L142 |
I updated the logic to use the oe-eval task suite -- the call for a reasoning model is now:
And for a non-reasoning model:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. We should wait to merge this until the oe-eval side of things is done (and then test before merging).
scripts/submit_eval_jobs.py
Outdated
# tested reasonably extensively with 70B | ||
if num_gpus > 1: | ||
num_gpus *= 2 | ||
if args.oe_eval_task_suite == 'SAFETY_EVAL' or args.oe_eval_task_suite == 'SAFETY_EVAL_REASONING': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline.
Let's remove the custom logic here and make it inline with everything else, but then for SAFETY_EVAL_REASONING specifically just double the num gpus.
…ai/open-instruct into maliam-update-safety-evals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this once oe-eval PR is merged! It would also be super useful if you do a quick test run with submit_eval_jobs before merging and link the succesful running jobs (one regular one reasoner).
This PR updates the call to safety evaluations in
submit_eval_jobs.py
by:oe-eval
for consistency--run_safety_evaluations_reasoning
option that runs the thinker safety eval suite throughoe-eval
oe-eval.sh
(necessary in order to use allenai/wildguard as a classifier in the safety evals)The beaker image
maliam/merge-safety-evals-0804-2
is compatible with this script, built off of this branch: https://github.com/allenai/oe-eval-internal/tree/maliam-add-safety-eval and this fork: https://github.com/mgmorgan23/safety-eval-forkExample call:
python scripts/submit_eval_jobs.py --model_name hf-open-thoughts-open-thinker3-7B --location open-thoughts/OpenThinker3-7B --is_tuned --evaluate_on_weka --workspace "tulu-3-results" --priority low --preemptible --beaker_image maliam/merge-safety-evals-0804-2 --use_hf_tokenizer_template --oe_eval_tasks "ifeval::tulu" --use_alternate_safety_image maliam/merge-safety-evals-0804-2 --skip_oi_evals --run_safety_evaluations_reasoning