Can we now remove the checks for AR5.1, please? #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solution is backward compatible with all Rails versions present on CI (5.1 >=).
Collaborator
|
Can we merge and release this please? |
|
Is there any additional work for this PR or can it be merged in? Thank you :) |
Contributor
Author
|
There's been no activity on this repo in about 3yrs. I think it's abandoned at this point. You can use my branch if you'd like. I'm still using the functionality but just try to keep it usable - not adding functionality or anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting deprecation warnings on some ActiveRecord51 checks in Devise code. This PR removes support for prior versions and gets rid of the warning.