Skip to content

Fix: GetPosition for buffer streams and Web hot reload/restard #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2025

Conversation

alnitak
Copy link
Owner

@alnitak alnitak commented Jun 28, 2025

Description

Fixes #258: now getPosition and getStreamTimeConsumed return the right time.

Fixes #259: hot reload and hot restart on Web, caused problems for the messaging JS Worker. Now it is recreated and should fix all the issues related to calls from WASM to Dart, soundEvents.listen stream for events included.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alnitak alnitak merged commit 2823b95 into main Jun 28, 2025
1 check passed
@alnitak alnitak deleted the fixGetPosition branch June 28, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: SoundEventType.handleIsNoMoreValid doesn't work after hot reload fix: getPosition has a bug in 3.1.12
1 participant