Skip to content

Restore logging of review app startup #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Restore logging of review app startup #6346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/govuk-frontend-review/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"license": "MIT",
"scripts": {
"dev": "gulp dev --color",
"dev": "cross-env-shell REVIEW_APP_SILENT_START=true gulp dev --color",
"prebuild": "npm run clean",
"build": "gulp build --color",
"build:sassdoc": "sassdoc --config sassdoc.config.yaml ../govuk-frontend/src/govuk",
Expand Down
19 changes: 14 additions & 5 deletions packages/govuk-frontend-review/src/start.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
import { ports } from '@govuk-frontend/config'
import { ports, urls } from '@govuk-frontend/config'

import app from './app.mjs'

const server = await app()

server.listen({
host: 'localhost',
port: ports.app
})
server.listen(
{
host: 'localhost',
port: ports.app
},
() => {
// Allow to disable the startup logs to avoid confusing users
// if other URLs are showed on screen (Browsersync's URLs, for ex.)
if (!process.env.REVIEW_APP_SILENT_START) {
console.log(`Review app started at ${urls.app}`)
}
}
)