Fix SQLite migrations table insert statements #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing
php artisan migrate:dump
with SQLite I discovered an error with the output where both of the first two insert statements had an id of 1, which caused thephp artisan migrate:load
command to fail. I traced to error to a hard-codedarray_slice()
call where potentially the current version of SQLite compared to an older version of SQLite produces slightly different output. Making the values of$insert_rows
dynamic fixes this issue with the current SQLite version and should also work with older versions as well.Tests
I added a second migration to specifically highlight this issue and updated all of the dump tests to check that it works correctly with all supported database drivers.
Call outs
I added the
ext-mbstring
extension to thecomposer.json
file due to variousmb_*
functions existing in the code base.