Skip to content

feat(language-service): add perf tracing for #getSemanticDiagnostics() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 37 commits into
base: ngtsc/perf/tracing
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
fbdb19c
docs(localize): expose documentation for the `@angular/localize` pack…
petebacondarwin Jan 5, 2021
2ccb579
feat(docs-infra): add profile picture size check (#41253)
AndrewKushnir Mar 17, 2021
3a55698
fix(core): remove obsolete check for [class] and [className] presence…
AndrewKushnir Mar 18, 2021
aa039a1
fix(compiler): correctly process multiple rules containing `:host` se…
petebacondarwin Mar 18, 2021
b012a56
docs: specify date format for reviewed tag (#41269)
yallen011 Mar 18, 2021
e8cae22
feat(dev-infra): validate breaking changes commit messages (#41274)
alan-agius4 Mar 19, 2021
5eb7f34
fix(dev-infra): remove commit message wizard and builder (#41280)
josephperrott Mar 19, 2021
ed5bfe8
docs: simplify deleteHero method in tutorial (#41303)
MariosRadis Mar 21, 2021
2548921
docs: reduce the file size of contributor images (#41292)
petebacondarwin Mar 20, 2021
5bc0a47
refactor(docs-infra): remove image size exclusion list (#41292)
petebacondarwin Mar 20, 2021
efe02d8
docs: update contributors.json (#41284)
cindygk Mar 19, 2021
f2f0eaf
docs(core): fix typos in interface docs (#41119)
petebacondarwin Mar 8, 2021
8868370
refactor(core): rename `...WithMeta` types to `...Declaration` and al…
petebacondarwin Mar 8, 2021
4dc27a7
refactor(core): rename `ɵɵFactoryDef` to `ɵɵFactoryDeclaration` (#41119)
petebacondarwin Mar 8, 2021
e7b1d43
refactor(compiler): use `ɵɵInjectorDeclaration` rather than `ɵɵInject…
petebacondarwin Mar 8, 2021
b555160
fix(router): fragment can be null (#37336)
MatthiasKunnen May 28, 2020
c49b280
fix(animations): cleanup DOM elements when the root view is removed (…
arturovt Mar 2, 2021
31dc483
docs: add alisa duncan to GDE resources (#41295)
alisaduncan Mar 20, 2021
e340d19
docs: add some boilerplate button, h3, and hr styles (#41052)
kapunahelewong Mar 2, 2021
ac66b01
build(docs-infra): remove unused contributor images (#41290)
gkalpak Mar 22, 2021
80f11a9
ci: check that there are no unused contributor images (#41290)
gkalpak Mar 22, 2021
1eba57e
fix(language-service): show suggestion when type inference is subopti…
alxhub Mar 3, 2021
190fa07
feat(router): add migration for ActivatedRouteSnapshot.fragment (#41092)
crisbeto Mar 15, 2021
6a6d332
docs: add Alexander Inkin to GDE list (#41310)
waterplea Mar 22, 2021
65f7d53
docs: add link to fork repo how-to (#41266)
yallen011 Mar 18, 2021
8d3da56
fix(ngcc): detect synthesized constructors that have been downleveled…
JoostK Mar 21, 2021
274dc15
fix(core): detect synthesized constructors that have been downleveled…
JoostK Mar 21, 2021
eba1289
docs: format browser-support tables for GitHub markdown (#41122)
leandrodiniz Mar 23, 2021
0516fbb
refactor(dev-infra): use conventional-commits-parser for commit parsi…
josephperrott Mar 19, 2021
a92a89b
docs: spelling changes in app.e2e-spec and validate-spec files (#41326)
MariosRadis Mar 23, 2021
81a0e71
ci: fix `elements` test on older browsers (#41324)
gkalpak Mar 23, 2021
3177d63
docs: update changelog for the v11.2.7 release
josephperrott Mar 24, 2021
9da7ea9
release: cut the v12.0.0-next.6 release (#41337)
josephperrott Mar 24, 2021
dd82c8e
docs(docs-infra): add Zach Arend to contributors.json (#41325)
zarend Mar 23, 2021
48fec08
perf(compiler-cli): refactor the performance tracing infrastructure (…
alxhub Mar 15, 2021
b61c009
build: emit performance JSON file for each ng_module() (#41125)
alxhub Mar 15, 2021
cc73af4
feat(language-service): add perf tracing to LanguageService
zarend Mar 19, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,13 @@ build:remote --remote_executor=remotebuildexecution.googleapis.com
# retry mechanism and we do not want to retry unnecessarily if Karma already tried multiple times.
test:saucelabs --flaky_test_attempts=1

################
# Flag Aliases #
################

# --ng_perf will ask the Ivy compiler to produce performance results for each build.
build --flag_alias=ng_perf=//packages/compiler-cli:ng_perf

####################################################
# User bazel configuration
# NOTE: This needs to be the *last* entry in the config.
Expand Down
44 changes: 44 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,47 @@
# 12.0.0-next.6 (2021-03-24)


### Bug Fixes

* **animations:** cleanup DOM elements when the root view is removed ([#41059](https://github.com/angular/angular/issues/41059)) ([c49b280](https://github.com/angular/angular/commit/c49b28013a6c017c9afc73bbc00bb4fdcf15c70e))
* **compiler-cli:** add `useInlining` option to type check config ([#41043](https://github.com/angular/angular/issues/41043)) ([09aefd2](https://github.com/angular/angular/commit/09aefd29045db77689f4dc16a6abae09a79cfb81)), closes [#40963](https://github.com/angular/angular/issues/40963)
* **core:** detect synthesized constructors that have been downleveled using TS 4.2 ([#41305](https://github.com/angular/angular/issues/41305)) ([274dc15](https://github.com/angular/angular/commit/274dc15452739e4fab2f647804a64d5b797cfed5)), closes [#41298](https://github.com/angular/angular/issues/41298)
* **ngcc:** detect synthesized constructors that have been downleveled using TS 4.2 ([#41305](https://github.com/angular/angular/issues/41305)) ([8d3da56](https://github.com/angular/angular/commit/8d3da56eda12070df1fb473c8609f3a94d77bfd6)), closes [#41298](https://github.com/angular/angular/issues/41298)
* **router:** fragment can be null ([#37336](https://github.com/angular/angular/issues/37336)) ([b555160](https://github.com/angular/angular/commit/b5551609fe02787641bdfdb0a6edfded413a3b52)), closes [#23894](https://github.com/angular/angular/issues/23894) [#34197](https://github.com/angular/angular/issues/34197)


### Features

* **router:** add migration for ActivatedRouteSnapshot.fragment ([#41092](https://github.com/angular/angular/issues/41092)) ([190fa07](https://github.com/angular/angular/commit/190fa07b9a416defb581d2bf76d1deef7baefce6)), closes [#37336](https://github.com/angular/angular/issues/37336)


### BREAKING CHANGES

* **animations:** DOM elements are now correctly removed when the root view is removed.
If you are using SSR and use the app's HTML for rendering, you will need
to ensure that you save the HTML to a variable before destorying the
app.
It is also possible that tests could be accidentally relying on the old behavior by
trying to find an element that was not removed in a previous test. If
this is the case, the failing tests should be updated to ensure they
have proper setup code which initializes elements they rely on.
* **router:** Strict null checks will report on fragment potentially being null.
Migration path: add null check.



## 11.2.7 (2021-03-24)


### Bug Fixes

* **compiler:** correctly process multiple rules containing `:host` selectors ([#41261](https://github.com/angular/angular/issues/41261)) ([f358d6b](https://github.com/angular/angular/commit/f358d6b113e1a8215fcb50dbc3c5db8799699901)), closes [#41237](https://github.com/angular/angular/issues/41237)
* **compiler-cli:** add `useInlining` option to type check config ([#41268](https://github.com/angular/angular/issues/41268)) ([57644e9](https://github.com/angular/angular/commit/57644e95aadbfe9c8f336be77a22f7a5e1859758)), closes [#40963](https://github.com/angular/angular/issues/40963)
* **core:** remove obsolete check for [class] and [className] presence ([#41254](https://github.com/angular/angular/issues/41254)) ([8a53b54](https://github.com/angular/angular/commit/8a53b5454eea7b4db09498d9018687aa0b0ca7f3))
* **language-service:** show suggestion when type inference is suboptimal ([#41072](https://github.com/angular/angular/issues/41072)) ([18cd7a0](https://github.com/angular/angular/commit/18cd7a0c6921983556fe1fffbff93d42ae138007)), closes [angular/vscode-ng-language-service#1155](https://github.com/angular/vscode-ng-language-service/issues/1155) [#41042](https://github.com/angular/angular/issues/41042)



# 12.0.0-next.5 (2021-03-17)


Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ Before you submit your Pull Request (PR) consider the following guidelines:
We cannot accept code without a signed CLA.
Make sure you author all contributed Git commits with email address associated with your CLA signature.

4. Fork the angular/angular repo.
4. [Fork](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo) the angular/angular repo.

5. Make your changes in a new git branch:
5. In your forked repository, make your changes in a new git branch:

```shell
git checkout -b my-fix-branch master
Expand Down
2 changes: 1 addition & 1 deletion aio/content/examples/interpolation/e2e/src/app.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ describe('Interpolation e2e tests', () => {
const label = element(by.css('label'));
expect(await label.getText()).toEqual('Type something:');
await input.sendKeys('abc');
expect(await label.getText()).toEqual('Type something: abc');
expect(await label.getText()).toMatch(/^Type something:\s+abc$/);
});
});
3 changes: 1 addition & 2 deletions aio/content/examples/toh-pt6/src/app/hero.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ export class HeroService {

// #docregion deleteHero
/** DELETE: delete the hero from the server */
deleteHero(hero: Hero | number): Observable<Hero> {
const id = typeof hero === 'number' ? hero : hero.id;
deleteHero(id: number): Observable<Hero> {
const url = `${this.heroesUrl}/${id}`;

return this.http.delete<Hero>(url, this.httpOptions).pipe(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class HeroesComponent implements OnInit {
// #docregion delete
delete(hero: Hero): void {
this.heroes = this.heroes.filter(h => h !== hero);
this.heroService.deleteHero(hero).subscribe();
this.heroService.deleteHero(hero.id).subscribe();
}
// #enddocregion delete

Expand Down
Loading