Skip to content

build, vendor: use dir="-" in create_missing_domain. #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2024
Merged

build, vendor: use dir="-" in create_missing_domain. #1443

merged 1 commit into from
Jun 30, 2024

Conversation

wanda-phi
Copy link
Member

Fixes #1402.

@wanda-phi wanda-phi requested a review from whitequark as a code owner June 30, 2024 03:03
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.12%. Comparing base (d4ec897) to head (0697556).
Report is 3 commits behind head on main.

Files Patch % Lines
amaranth/build/plat.py 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
+ Coverage   91.06%   91.12%   +0.06%     
==========================================
  Files          43       43              
  Lines       10967    10990      +23     
  Branches     2375     2665     +290     
==========================================
+ Hits         9987    10015      +28     
  Misses        804      804              
+ Partials      176      171       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

whitequark
whitequark approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whitequark whitequark added this to the 0.6 milestone Jun 30, 2024
@whitequark whitequark added this pull request to the merge queue Jun 30, 2024
Merged via the queue into amaranth-lang:main with commit eefca83 Jun 30, 2024
@wanda-phi wanda-phi deleted the missing-domain branch June 30, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
backport:v0.5
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

create_missing_domain uses platform.request() in deprecated mode in all platforms
2 participants
@wanda-phi @whitequark