Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions Documentation/devicetree/bindings/iio/dac/adi,ad5413.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/iio/dac/adi,ad5413.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: Analog Devices AD5413 DAC

maintainers:
- Bruce Tsao <[email protected]>

properties:
compatible:
const: adi,ad5413

reg:
maxItems: 1

spi-max-frequency:
maximum: 50000000

reset-gpios: true

avdd-supply:
description: Analog positive supply (AVDD)

dvdd-supply:
description: Digital positive supply (DVDD)

avss-supply:
description: Analog negative supply (AVSS)

adi,range-microvolt:
description: Voltage output range <min, max> in microvolts
oneOf:
- items:
- const: -10500000
- const: 10500000
- items:
- const: -12600000
- const: 12600000

adi,range-microamp:
description: Current output range <min, max> in microamps
items:
- const: 0
- const: 24000

adi,slew-time-us:
description: Output digital slew control time in microseconds
minimum: 0
maximum: 1000000
default: 0

required:
- compatible
- reg
- spi-max-frequency
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really mandatory? Typically not...

- avdd-supply
- dvdd-supply
- avss-supply

allOf:
- $ref: /schemas/spi/spi-peripheral-props.yaml#
- oneOf:
- required: ['adi,range-microamp']
- required: ['adi,range-microvolt']

unevaluatedProperties: false

examples:
- |
spi {
#address-cells = <1>;
#size-cells = <0>;
dac@0 {
compatible = "adi,ad5413";
reg = <0>;
spi-max-frequency = <1000000>;
reset-gpios = <&gpio 0 1>; /* 1 = active low */
avdd-supply = <&avdd>;
dvdd-supply = <&dvdd>;
avss-supply = <&avss>;
adi,range-microamp = <0 24000>;
adi,slew-time-us = <125>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bindings patch should be one separate commit.

};
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just about the commit message. Do not mention "bindings" in the git subject, that's implied :). Instead, something like
"dt-bindings: iio: dac: Document AD5413 properties"

1 change: 1 addition & 0 deletions drivers/iio/Kconfig.adi
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ config IIO_ALL_ADI_DRIVERS
imply AD5360
imply AD5380
imply AD5421
imply AD5413
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a separate commit. The last one typically...

imply AD5624R_SPI if SPI
imply AD3552R
imply AD3552R_HS
Expand Down
11 changes: 10 additions & 1 deletion drivers/iio/dac/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,16 @@ config AD5380
To compile this driver as module choose M here: the module will be called
ad5380.

config AD5413
tristate "Analog Devices AD5413 DAC driver"
depends on SPI_MASTER
help
Say yes here to build support for Analog Devices AD5413 single channel
Digital to Analog Converter.

To compile this driver as a module, choose M here: the
module will be called ad5413.

config AD5421
tristate "Analog Devices AD5421 DAC driver"
depends on SPI
Expand Down Expand Up @@ -597,5 +607,4 @@ config VF610_DAC

This driver can also be built as a module. If so, the module will
be called vf610_dac.

endmenu
1 change: 1 addition & 0 deletions drivers/iio/dac/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ obj-$(CONFIG_AD3552R) += ad3552r.o
obj-$(CONFIG_AD5270) += ad5270.o
obj-$(CONFIG_AD5360) += ad5360.o
obj-$(CONFIG_AD5380) += ad5380.o
obj-$(CONFIG_AD5413) += ad5413.o
obj-$(CONFIG_AD5421) += ad5421.o
obj-$(CONFIG_AD5624R_SPI) += ad5624r_spi.o
obj-$(CONFIG_AD5064) += ad5064.o
Expand Down
Loading
Loading