Change check_sigs to on by default #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should protect perl users out-of-the box by checking their module signatures unless they've told us otherwise.
When check_sigs was set to 0 for first time users 13 years ago, there was a concern that signature checking apparatus wasn't sufficiently mature. With more than a decade behind us, perhaps we could consider enabling this now as a sensible default.
If Module::Signature isn't installed, users are still able to install modules, just with a reminder to please install Module::Signature if they'd like to verify modules, so this change shouldn't exclude or break anyone.