-
Notifications
You must be signed in to change notification settings - Fork 8
Remove tv-material from the dependencies #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @chikoski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on modernizing the Adaptive JetStream project by removing the tv-material
dependency and migrating its sole used component, Carousel
, to the HorizontalCenteredHeroCarousel
from the standard Compose Material3 library. This change not only updates the UI component but also involves a comprehensive update of various Android, Compose, and Gradle versions, ensuring the project leverages the latest platform capabilities and best practices. The refactoring also includes adjustments to focus management and the removal of deprecated or replaced custom logic, leading to a cleaner and more maintainable codebase.
Highlights
- Dependency Removal: The
tv-material
dependency has been completely removed from the project'slibs.versions.toml
andbuild.gradle.kts
files, streamlining the dependency graph. - Carousel Component Migration: The
Carousel
component, previously fromandroidx.tv.material3
, has been replaced withHorizontalCenteredHeroCarousel
from the standardandroidx.compose.material3.carousel
library. This involves significant changes inFeaturedMoviesCarousel.kt
andFeaturedMoviesCarouselState.kt
to adapt to the new API. - Version Updates: The project's
compileSdk
andtargetSdk
versions have been updated from 35 to 36, and the Gradle distribution has been upgraded to 8.13. Numerous other AndroidX and Compose library versions have also been bumped to their latest stable or beta releases. - Codebase Simplification: The custom
DragDetector.kt
file, which handled drag gestures for the carousel, has been removed, as its functionality is now likely integrated or handled differently by the new Material3 carousel component. - UI/UX Enhancements: Focus handling for the 'Watch Now' button in
WatchNowButton.kt
has been enhanced to automatically request focus on TV devices, improving user experience.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes the tv-material
dependency and replaces its Carousel
with HorizontalCenteredHeroCarousel
from Compose Material 3. The accompanying dependency updates and refactoring are well-executed. My review includes a few suggestions to enhance functionality and code structure, such as restoring the clickability of carousel items for a better user experience on mobile and simplifying focus management.
This pull request removes tv-material from the dependencies of Adaptive JetStream.
Carousel
is the only component from tv-material, which is used in this project. This pull request replaces it withHorizontalCenteredHeroCarousel
from Compose Material3 library.