-
Notifications
You must be signed in to change notification settings - Fork 8
Create first sample for WSC L and XL #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @tiwiz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers a foundational Android Compose sample application. Its primary purpose is to illustrate the practical application of Window Size Classes, particularly the newly introduced Large and Extra Large breakpoints, to enable developers to build responsive user interfaces that adapt seamlessly across various screen sizes and device form factors.
Highlights
- New Sample Application: This pull request introduces a brand new Android Compose sample application designed to demonstrate the usage and behavior of Window Size Classes, specifically focusing on the new Large (L) and Extra Large (XL) breakpoints.
- Window Size Class Implementation: The sample showcases how to retrieve and interpret window size information using both the
androidx.window
library and thematerial3.adaptive
APIs. It defines customWidth
andHeight
enums to categorize window dimensions, including the new 'Large' and 'ExtraLarge' width classifications. - Adaptive UI with Compose: The application's UI is built with Jetpack Compose and dynamically adapts its layout based on the detected window size class. It visually represents the current width and height classifications, providing a clear demonstration of adaptive design principles.
- Build Configuration: The PR includes a complete Gradle setup for a modern Android Compose project, utilizing Kotlin DSL for build scripts and managing dependencies via
libs.versions.toml
, including the necessarymaterial3-adaptive
,material3-window-size-class
, andandroidx.window
libraries.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request sets up a new sample application to demonstrate Window Size Classes, particularly for Large and Extra Large screens. The project structure, Gradle configuration, and basic Android components are well-defined.
My review focuses on improving code safety and idiomatic Kotlin usage in the core logic files. I've identified a potential null pointer exception in Content.kt
and suggested improvements for code consistency in WscUtils.kt
. These changes will make the sample more robust and easier to understand.
WindowSizeClassSample/app/src/main/java/com/google/sample/wsc/lxl/ui/Content.kt
Outdated
Show resolved
Hide resolved
WindowSizeClassSample/app/src/main/java/com/google/sample/wsc/lxl/utils/WscUtils.kt
Outdated
Show resolved
Hide resolved
…lxl/ui/Content.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.