-
Notifications
You must be signed in to change notification settings - Fork 56
Add recipe showing how to model more complex back stack behavior #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dturner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've added a new recipe to demonstrate more complex back stack behavior in Android Compose using a custom Navigator class. This recipe provides a flexible way to manage navigation, including nested and shared routes, and showcases how to integrate it with a NavDisplay.
Highlights
- Custom Navigator Class: Introduced a custom Navigator class in Navigator.kt to model advanced navigation behavior, including a mutable back stack, top-level routes, and shared routes.
- Example NavigatorActivity: Implemented NavigatorActivity.kt as a practical example, demonstrating how to use the Navigator with a bottom navigation bar and a search functionality.
- Unit Tests for Navigator: Added comprehensive unit tests in NavigatorTest.kt to validate the Navigator's behavior across various scenarios, such as navigating to top-level routes, handling shared routes, and managing the back stack.
- Build Configuration Update: Updated app/build.gradle.kts to include the Kotlin test dependency for the new unit tests.
- Android Manifest Update: Registered the new NavigatorActivity in app/src/main/AndroidManifest.xml.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new recipe for modeling complex back stack behavior using a custom Navigator
class. The implementation is well-structured with a corresponding activity and unit tests. My review focuses on a critical bug in the back navigation logic that could lead to a crash, along with several medium-severity issues related to code robustness, performance, accessibility, and test clarity. Addressing these points will improve the quality and reliability of the new recipe.
WIP