-
Notifications
You must be signed in to change notification settings - Fork 56
Create SupportingPaneStrategy Recipe #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @tiwiz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new adaptive layout recipe, MaterialSupportingPaneActivity
, which demonstrates the use of Material Design 3's SupportingPaneSceneStrategy
for creating flexible multi-pane user interfaces. It also includes essential updates to project dependencies and a minor refactoring in an existing two-pane example to ensure compatibility and leverage the latest navigation components.
Highlights
- New Recipe: Material Supporting Pane Layout: Introduced a new recipe demonstrating the
SupportingPaneSceneStrategy
from Material Design 3 adaptive navigation. This example showcases a three-pane layout with Main, Supporting, and Extra panes, adapting to different window sizes. - Dependency Updates: Updated various project dependencies, including Android Gradle Plugin, Kotlin, Compose BOM, Navigation3, Material3, and Hilt, to their latest alpha/release candidate versions.
- Two-Pane Activity Refactoring: Refactored the
TwoPaneActivity
to utilizeNavBackStack
directly for managing product routes, aligning with updated Navigation3 patterns and removing the dependency onSnapshotStateList
. - Manifest and Recipe Picker Integration: Registered the new
MaterialSupportingPaneActivity
inAndroidManifest.xml
and added it to theRecipePickerActivity
list, making it accessible from the main application menu.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new activity, MaterialSupportingPaneActivity
, which demonstrates the use of the SupportingPaneSceneStrategy
for creating adaptive layouts. The activity is added to the AndroidManifest.xml
and registered in RecipePickerActivity.kt
. Additionally, library versions in gradle/libs.versions.toml
have been updated. I have identified a potential issue with the copyright year in the new file.
...java/com/example/nav3recipes/scenes/materialsupportingpane/MaterialSupportingPaneActivity.kt
Show resolved
Hide resolved
# Conflicts: # gradle/libs.versions.toml
No description provided.