Bump Robolectric to 4.15.1 #2590
Conversation
| @@ -357,6 +358,9 @@ public void onLoadCompleted( | |||
| .ignoringNonFatalErrors() | |||
| .untilBackgroundThreadCondition(() -> secondSubtitleFailureCount.get() == 4); | |||
| secondSubtitleResolves.set(true); | |||
|
|
|||
| ShadowLooper.runUiThreadTasks(); | |||
There was a problem hiding this comment.
Can you explain what issue this is addressing and how it is solved by this line.
In any case I think I'd prefer to separate bumping the version and applying a fix for the dash playback test. When I add this line without bumping the version it appears that this would work as well, so I think these two changes can be separated.
If you can provide me with the reasoning for this change here, I can do a CL internally that bumps the robolectric version and we can then turn this change here to a commit that addresses the problem you are seeing.
There was a problem hiding this comment.
This change is safe on the old version, and is used to avoid extra Robolectrie's looper left runnable checking. I can send a new PR for this change separately with old Robolectric version.
There was a problem hiding this comment.
Would be great to split this, yes!
There was a problem hiding this comment.
#2628 New pr for test code changes.
Test: ./gradlew test --info Signed-off-by: utzcoz <[email protected]>
icbaker
force-pushed
the
robolectric-4.15.1
branch
from
858e2ce to
5cb212b
Compare
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
Bump Robolectric to 4.15.1 and adapt test code to flush runnables before internal checking.