Remove duplicated Modifier usages in :demos:compose
#2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
force-pushed
the
remove_redundant_modifier
branch
2 times, most recently
from
6a44a39 to
72ef093
Compare
The `modifier` argument is already applied to the root `IconButton`. It is wrong to also apply it to the child `Icon`.
oceanjules
force-pushed
the
remove_redundant_modifier
branch
from
72ef093 to
1f2fdef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
modifierargument is already applied to the rootIconButton. It is wrong to also apply it to the childIcon.