-
Notifications
You must be signed in to change notification settings - Fork 582
Remove outdated qualifiers on resources folders #2685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
shouldn't this also remove .png files for example in ui library? while the .png files would still be used on devices that exactly match the standard dpi qualifiers, anydpi .xml files will be used for any other dpi, and frankly there is no reason to keep the app size bloat that are these .png files anymore as anydpi vector drawables work just fine for these. |
Good point! I'll look into removing the PNG files when there is a vector equivalent |
Yes, it should, thanks for noting! These pngs only existed to support API<21 devices, so can now be removed entirely. |
420bd6b
to
9f6154f
Compare
Done. I've removed PNG files that already have a vector equivalent in a0d7ba3, and converted Note There's still |
9f6154f
to
c00d28f
Compare
c00d28f
to
6fae214
Compare
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
@rohitjoins with e42940c, the content of https://github.com/androidx/media/blob/main/libraries/session/src/main/res/values-v21/styles.xml is no longer applied. Is it ok? |
@MGaetan89 yes, that change is intentional. This is because the values are now provided by the base
That's a great observation. Will remove that file too! Thanks! |
Some resources were still in the
-v21
/-v22
/-v23
resources folders.This PR moves them to the main folder, updating the original files when needed.