ref: Osmosis socket queries #971
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| from_denom, | ||
| to_denom, | ||
| } => encode_binary(&query_get_route(deps, from_denom, to_denom)?), | ||
| QueryMsg::PoolInfo { creator } => { |
There was a problem hiding this comment.
We need to store pool info using factory denoms pair as 1 creator can create multiple pools
There was a problem hiding this comment.
One creator can also create multiple pools using the same denoms pair. I'm thinking a state of pool_id to pool info would be best.
And if the user forgot the pool's id, he can check using the PoolsCreated query
| SPENDER.remove(deps.storage); | ||
| let spender_and_params = SPENDER_AND_PARAMS.load(deps.storage)?; | ||
| SPENDER_AND_PARAMS.remove(deps.storage); | ||
|
|
There was a problem hiding this comment.
All the pool types will add the states to Pools Created and PoolQuery
There was a problem hiding this comment.
Can you elaborate on this?
Motivation
Getting PoolId was difficult
Implementation
Testing
Was there any on-chain, or other types, of testing run with this change?
Version Changes
Checklist