Skip to content

chore(deps): update dependencies so that angular-ui-sortable is optional #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyperlitch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update dependencies so that angular-ui-sortable is optional #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ node_js:
before_script:
- 'npm install -g bower grunt-cli'
- 'bower install'

6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ With bower:
bower install angularjs-table
```

Dependencies
------------

The only real dependencies for this library are angular and angular-sanitize. You can optionally include `angular-ui-sortable`, which relies on jquery. This will enable the column sorting via drag-and-drop. Without the presence of `angular-ui-sortable`, the library should work just fine, but without the ability for the user to change the order of the columns via drag-and-drop.


Getting Started
---------------

Expand Down
2 changes: 1 addition & 1 deletion app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@

<!-- build:js scripts/vendor.js -->
<!-- bower:js -->
<script src="bower_components/jquery/jquery.js"></script>
<script src="bower_components/jquery/dist/jquery.js"></script>
<script src="bower_components/angular/angular.js"></script>
<script src="bower_components/angular-sanitize/angular-sanitize.js"></script>
<script src="bower_components/angular-animate/angular-animate.js"></script>
Expand Down
12 changes: 8 additions & 4 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@
],
"dependencies": {
"angular": "^1.6",
"jquery": "~2.0.3",
"angular-sanitize": "^1.6",
"angular-ui-sortable": "~0.13",
"jquery-ui": ">=1.11.0"
"angular-sanitize": "^1.6"
},
"optionalDependencies": {
"jquery-ui": ">=1.11.0",
"angular-ui-sortable": "~0.13"
},
"devDependencies": {
"jquery": "~2",
"angular-ui-sortable": "~0.13",
"jquery-ui": ">=1.11.0",
"angular-route": "^1.6",
"bootstrap": "~3.0.3",
"angular-mocks": "^1.6",
Expand Down
9 changes: 6 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@
"version": "2.21.5",
"license": "Apache License, v2.0",
"dependencies": {
"angular": "^1.6",
"jquery": "~2",
"angular-sanitize": "~1.3"
"angular": "^1.4",
"angular-sanitize": "^1.4"
},
"optionalDependencies": {
"jquery-ui": ">=1.11.0",
"angular-ui-sortable": "~0.13"
},
"repository": "https://github.com/andyperlitch/angularjs-table",
"types": "./angular-mesa.d.ts",
Expand Down