Skip to content

Conversation

@MiniPierre
Copy link

SUMMARY

This pull request adds default values to each vhost permission set in permission variable if not defined

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rabbitmq_user

ADDITIONAL INFORMATION

N/A

Added default values for permissions defined in the `permission` variable
@MiniPierre
Copy link
Author

MiniPierre commented Jul 7, 2021

Failing tests seem to be due to missing dependecies and not because of the pull request itself

@Andersson007
Copy link
Contributor

@MiniPierre hi, please

  1. add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment.
  2. could you explain what the issue is? I.e. how these default values will help?
  3. does not this break backwards compatibility?

@chrishoffman @manuel-sousa @jgkirschbaum @h-matsuo you were members of rabbitmq team in ansible/ansible / module authors and you were invited to this repo as maintainers. Are you still interested in supporting the stuff here?

@Andersson007
Copy link
Contributor

Andersson007 commented Jul 16, 2021

@Andersson007
Copy link
Contributor

cc @MiniPierre ^

@cognifloyd
Copy link
Collaborator

@MiniPierre I'm a fan of merging PRs 😉 Will you have time to rebase this soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants