AMW-162 Add support for KRaft #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanabirChakraborty
force-pushed
the
AMW-162
branch
30 times, most recently
from
16ec91e to
b656230
Compare
RanabirChakraborty
force-pushed
the
AMW-162
branch
13 times, most recently
from
a63d488 to
a9f9ab0
Compare
RanabirChakraborty
added
enhancement
Member
Author
|
For molecule testing purpose I have changed the github workflow ci.yml branch from main to AMW-162, once the review is done I'll change it back to main again. so please ignore that. |
iweiss
reviewed
Dec 12, 2025
| {% if amq_streams_broker_listeners is defined %} | ||
| listeners={{ amq_streams_broker_listeners | join(",") }} | ||
| {% elif amq_streams_broker_listener_port is defined %} | ||
| {% elif amq_streams_broker_listener_port is defined %} |
iweiss
reviewed
Dec 12, 2025
| {% else %} | ||
| # Legacy ZK Mode Advertised Listeners | ||
| {% if amq_streams_broker_advertised_listeners is defined %} | ||
| advertised.listeners={{ amq_streams_broker_advertised_listeners | join(",") }} |
iweiss
reviewed
Dec 12, 2025
| # KRaft Mode Security Map (Must include Controller) | ||
| listener.security.protocol.map=PLAINTEXT:PLAINTEXT,CONTROLLER:PLAINTEXT,SSL:SSL,SASL_PLAINTEXT:SASL_PLAINTEXT,SASL_SSL:SASL_SSL | ||
| {% else %} | ||
| {% if amq_streams_broker_auth_enabled and amq_streams_broker_auth_listeners is defined %} |
iweiss
reviewed
Dec 12, 2025
| # The list of SASL mechanisms enabled in the Kafka server | ||
| sasl.enabled.mechanisms={{ amq_streams_broker_auth_sasl_mechanisms | join(",") }} | ||
| {% if amq_streams_broker_inter_broker_auth_sasl_mechanisms is defined %} | ||
| {% if amq_streams_broker_inter_broker_auth_sasl_mechanisms is defined %} |
Member
Author
There was a problem hiding this comment.
Corrected. Please review once.
RanabirChakraborty
force-pushed
the
AMW-162
branch
from
a9f9ab0 to
6ccde12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/AMW-162
GitHub issue: #124