-
Notifications
You must be signed in to change notification settings - Fork 5
To support port 8443 instead of 8080 for chatbot and service communication over on-prem #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Quick assessment:
In openshift, there are tricks to use annotations to automatically set up certs, but we don't have that available to us in k8s. |
@rooftopcellist thanks for reviewing the PR, I updated and verified the suggestion made as:
This would help admins to pass the custom CA, is that correct expectation?
And, post update the communication happens as expected w/o issues. Around your following comment:
I believe you meant the following model and chat deployment:
So, based on your suggestion you mean to make use of existing bundle CA system that's already properly configured for Python containers, instead of pointing to platform-specific certificate paths like:
Correct?
Please excuse me for my understanding as I thought operators would be used only via Openshift. And, I wanted to understand that will bundling CA could provide operator-level automation for both platforms(openshift/k8s) |
The Seems to be installed with OCP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the volumeMounts
may need revisiting.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my (limited) understanding of TLS; this LGTM 👍
@justjais The failing molecule tests:
Are probably caused by ansible/ansible-ai-connect-service#1757 The test expects |
@justjais There may be other tests too.. you should check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank-you.
Jira Issue: https://issues.redhat.com/browse/AAP-50667
Description
To support port 8443 instead of 8080 for chatbot and service communication over on-prem
Testing
Steps to test
Cluster setup is at:
https://console-openshift-console.apps.aap-test2.w6n5.p1.openshiftapps.com/, under aap-50667 namespace, as verified the chatbot status ref:
Model pipeline configuration used:
Llama-stack is serving using https, as:
https://0.0.0.0:8321/
Scenarios tested
NA
Production deployment