community/create_pr_quick_start.rst: update, improve. Assisted-by: Gemini #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andersson007
added
backport-2.17
|
ready for review |
samccann
reviewed
Jul 16, 2025
|
|
||
| .. note:: | ||
|
|
||
| If there are any difficulties with writing or running the tests or you are not sure if the case can be covered, you can skip this step. Other contributors can help you with tests later if needed. | ||
| * Some collections do not have integration tests. In such cases, unit tests are highly recommended. | ||
| * If you have difficulty writing or running tests, or you are unsure if a case can be covered, skip this step. Other contributors can help you with tests later if needed. |
There was a problem hiding this comment.
View this file in github and you'll see this note isn't formatted properly.
|
|
||
| .. note:: | ||
|
|
||
| If you are not sure whether you should use the default image for testing or a specific one, skip the entire step - the community can help you later. You can also try to use the collection repository's CI to figure out which containers are used. | ||
| * Some collections do not have unit tests. In such cases, focus on integration tests. | ||
| * If you have difficulty writing or running tests, or you are unsure if a case can be covered, skip this step. Other contributors can help you with tests later if needed. |
There was a problem hiding this comment.
Same problem with this note.
|
@Andersson007 fyi some fixes needed here. |
Yes, I remember, i'll fix it once I'm back from PTO, thanks for pinging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
community/create_pr_quick_start.rst: update, improve. Assisted-by: Gemini