-
Notifications
You must be signed in to change notification settings - Fork 700
breaking: Renamed rule class methods (naming convention) #4666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave a fall back to the old call is place with warning that the API is changing? I'm not sure how many people have custom rules, but we can't just break it in a single release.
b925b83
to
acb89d3
Compare
Based on https://sourcegraph.com/search?q=context%3Aglobal+lang%3Apython+AnsibleLintRule+-repo%3Aansible%2Fansible-lint&patternType=keyword&sm=0&expanded= I think we can (obviously with an update to the correct versioning, not as a patch level version change.) |
Renames - matchyaml -> match_file - matchtask -> match_task - matchtasks -> match_tasks - matcherror -> match_error - matchvar -> match_var - matchdir -> match_dir - create_matcherror -> create_match_error
9a2907b
to
2a55cd2
Compare
I love sourcegraph. Unfortunately, it wouldn't be able to see any rules internal to an enterprise. |
Label error. Requires exactly 1 of: breaking, build, chore, ci, docs, feat, fix, perf, refactor, style, test. Found: . Follow https://www.conventionalcommits.org to get auto-labeling to work correctly. |
This change will require custom rule users to update their rules to use the new API.
Renames made:
This change also improves how we run cspell in order to automatically sort the dictionary and to remove unused entries.
That idea came while reviewing #4662 with @shatakshiiii and realizing that the incorrect historical naming made the development of the new rule harder.