FEAT: emit_schematic_feature #6249

ramin4667 · 2025-06-09T19:44:34Z

Description

This PR adds the schematic module to the feature branch F932911.

Issue linked

NA.

Checklist

I have tested my changes locally.
I have added necessary documentation or updated existing documentation.
I have followed the coding style guidelines of this project.
I have added appropriate tests (unit, integration, system).
I have reviewed my changes before submitting this pull request.
I have linked the issue or issues that are solved by the PR if any.
I have agreed with the Contributor License Agreement (CLA).

Reconfigure Revision class for some API changes

…ethods to Revision and make revision-aware, add methods for getting individual top level nodes

Update the revision/result classes to support new api

use display names for access nodes

add units support

fix conversion from string to decimal+string

…fault units

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…F932911

…fix capitalization of new generated nodes

Co-authored-by: Sébastien Morais <[email protected]>

ansys-reviewer-bot · 2025-06-09T19:44:37Z

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov · 2025-06-09T19:57:41Z

Codecov Report

❌ Patch coverage is 55.81446% with 4077 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.40%. Comparing base (d97a29e) to head (5840e0a).
⚠️ Report is 219 commits behind head on main.

❌ Your patch status has failed because the patch coverage (55.81%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6249       +/-   ##
===========================================
- Coverage   85.25%   38.40%   -46.86%     
===========================================
  Files         170      286      +116     
  Lines       64100    76624    +12524     
===========================================
- Hits        54647    29424    -25223     
- Misses       9453    47200    +37747

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

into emit_schematic_feature

Fix antenna_node

jsalant22 · 2025-06-11T18:51:47Z

@ramin4667 Can you take a look at the merge conflicts? Since they're all in the generated nodes, I'm guessing we want to accept all the changes from the main feature branch.

…ture # Conflicts: # src/ansys/aedt/core/emit_core/nodes/generated/antenna_node.py # src/ansys/aedt/core/emit_core/nodes/generated/band.py # src/ansys/aedt/core/emit_core/nodes/generated/band_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/cad_node.py # src/ansys/aedt/core/emit_core/nodes/generated/circulator.py # src/ansys/aedt/core/emit_core/nodes/generated/coupling_link_node.py # src/ansys/aedt/core/emit_core/nodes/generated/coupling_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/custom_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/emi_plot_marker_node.py # src/ansys/aedt/core/emit_core/nodes/generated/erceg_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/five_g_channel_model.py # src/ansys/aedt/core/emit_core/nodes/generated/hata_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/indoor_propagation_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/isolator.py # src/ansys/aedt/core/emit_core/nodes/generated/log_distance_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/mplex_band_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/multiplexer.py # src/ansys/aedt/core/emit_core/nodes/generated/outboard_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/parametric_coupling_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/plot_marker_node.py # src/ansys/aedt/core/emit_core/nodes/generated/plot_node.py # src/ansys/aedt/core/emit_core/nodes/generated/power_divider.py # src/ansys/aedt/core/emit_core/nodes/generated/power_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/profile_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/propagation_loss_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_antenna_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_band.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_cad_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_circulator.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_coupling_link_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_custom_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_erceg_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_five_g_channel_model.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_hata_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_indoor_propagation_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_isolator.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_log_distance_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_multiplexer.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_power_divider.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_propagation_loss_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_rx_meas_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_rx_selectivity_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_rx_susceptibility_prof_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_sampling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_scene_group_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_solution_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_solutions_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_touchstone_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_tr_switch.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_two_ray_path_loss_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_tx_bb_emission_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_tx_meas_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_tx_spectral_prof_emitter_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_tx_spectral_prof_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_walfisch_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/read_only_waveform.py # src/ansys/aedt/core/emit_core/nodes/generated/result_plot_node.py # src/ansys/aedt/core/emit_core/nodes/generated/rx_meas_node.py # src/ansys/aedt/core/emit_core/nodes/generated/rx_selectivity_node.py # src/ansys/aedt/core/emit_core/nodes/generated/rx_susceptibility_prof_node.py # src/ansys/aedt/core/emit_core/nodes/generated/sampling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/scene_group_node.py # src/ansys/aedt/core/emit_core/nodes/generated/selectivity_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/solution_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/solutions_node.py # src/ansys/aedt/core/emit_core/nodes/generated/spur_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/test_noise_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/touchstone_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/tr_switch.py # src/ansys/aedt/core/emit_core/nodes/generated/tr_switch_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/tunable_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/two_ray_path_loss_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/two_tone_trace_node.py # src/ansys/aedt/core/emit_core/nodes/generated/tx_bb_emission_node.py # src/ansys/aedt/core/emit_core/nodes/generated/tx_meas_node.py # src/ansys/aedt/core/emit_core/nodes/generated/tx_spectral_prof_emitter_node.py # src/ansys/aedt/core/emit_core/nodes/generated/tx_spectral_prof_node.py # src/ansys/aedt/core/emit_core/nodes/generated/walfisch_coupling_node.py # src/ansys/aedt/core/emit_core/nodes/generated/waveform.py

ramin4667 · 2025-06-17T15:59:15Z

@ramin4667 Can you take a look at the merge conflicts? Since they're all in the generated nodes, I'm guessing we want to accept all the changes from the main feature branch.

@jsalant22 conflicts are solved and merged.

The base branch was changed.

jsalant22 and others added 30 commits January 22, 2025 10:13

EMIT API branch

935d091

Reconfigure Revision class for some API changes

Add first draft of generated nodes and basic interface

f14755b

New version of generated nodes

4aef45e

Updated generated nodes and interface

3cce1c1

Add generated module init file, update EmitNode

04c4218

Add node functions for getting children

3f33e2a

Update generated nodes spacing and add_ methods, move NodeInterface m…

bfef0cf

…ethods to Revision and make revision-aware, add methods for getting individual top level nodes

Add equality operator to EmitNode class

3aac82f

Remove equality operator from generated nodes

70100fd

update revision and result classes for api changes

84f6c32

Update the revision/result classes to support new api

Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911

5d0ece1

use display names for access nodes

68034da

use display names for access nodes

add units support

fcee90c

add units support

fix unit parsing

c280da2

fix conversion from string to decimal+string

Add updated generated nodes, fix emit allowed unit names, fix emit de…

32060dd

…fault units

Fix revision constructor for 252, fix units

6a06ab5

Update results and revision modules to use new result API

5501be5

Revert change of GetKeptResultProperties to GetResultProperties

0633784

Add EmitterBand and TxSpectralProfEmitter classes (#6048)

f5b5780

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Add test for generated nodes

5a01894

Fix merge conflict

55bb89d

Add warning for disconnected comps (#6056)

726e6d4

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

F1251272 (#6063)

4b68e24

Add dynamic generated node test

95189be

Fix conflict

39fd586

Fix merge conflicts for files deleted in main

98d0248

CHORE: Auto fixes from pre-commit hooks

5fba8f8

chore: adding changelog file 6068.added.md [dependabot-skip]

4c74e09

Re-delete readded files

16d567f

Merge branch 'F932911' of ssh://ssh.github.com:443/ansys/pyaedt into …

05e89d9

…F932911

jsalant22 and others added 9 commits May 21, 2025 12:55

remove lint comments

ca17091

CHORE: Auto fixes from pre-commit hooks

42b3098

Use absolute imports, use common AEDT major version guard decorator, …

2f03278

…fix capitalization of new generated nodes

Remove test file

17c3fe2

CHORE: Auto fixes from pre-commit hooks

72efa75

Update src/ansys/aedt/core/emit_core/emit_constants.py

dcb38aa

Co-authored-by: Sébastien Morais <[email protected]>

Fix all docstrings in generated EMIT classes

a30cbbb

Fix power unit in radio_component test

ec05d69

Initial commit

6b1ba5a

ramin4667 requested a review from a team as a code owner June 9, 2025 19:44

pyansys-ci-bot and others added 2 commits June 9, 2025 19:46

chore: adding changelog file 6249.added.md [dependabot-skip]

cfbd191

CHORE: Auto fixes from pre-commit hooks

6e749c8

ramin4667 added 2 commits June 10, 2025 15:37

updating to return Emit node instead of ID

af1b65d

Merge branch 'emit_schematic_feature' of https://github.com/ansys/pyaedt

a1fe8f6

into emit_schematic_feature

ramin4667 requested a review from jsalant22 June 10, 2025 19:40

update bool get/set

2a1ac4f

Fix antenna_node

ramin4667 added 5 commits June 13, 2025 13:24

id is replaced by comp_id

0726357

true value correction

e1b5f4d

id replacement with comp_id

66c72cf

more id replacement with comp_id

5840e0a

jsalant22 previously approved these changes Jun 18, 2025

View reviewed changes

Base automatically changed from F932911 to main July 22, 2025 12:40

Samuelopez-ansys marked this pull request as draft August 5, 2025 05:48

jsalant22 closed this Sep 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FEAT: emit_schematic_feature #6249

FEAT: emit_schematic_feature #6249

Uh oh!

ramin4667 commented Jun 9, 2025

Uh oh!

ansys-reviewer-bot bot commented Jun 9, 2025

Uh oh!

codecov bot commented Jun 9, 2025 •

edited

Loading

Uh oh!

jsalant22 commented Jun 11, 2025

Uh oh!

ramin4667 commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FEAT: emit_schematic_feature #6249

FEAT: emit_schematic_feature #6249

Uh oh!

Conversation

ramin4667 commented Jun 9, 2025

Description

Issue linked

Checklist

Uh oh!

ansys-reviewer-bot bot commented Jun 9, 2025

Uh oh!

codecov bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jsalant22 commented Jun 11, 2025

Uh oh!

ramin4667 commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jun 9, 2025 •

edited

Loading