Skip to content

Conversation

hui-zhou-a
Copy link
Contributor

correct edbversion as input to ViaDesignBackend

@hui-zhou-a hui-zhou-a requested a review from a team as a code owner July 24, 2025 09:45
@ansys-cla-bot
Copy link

ansys-cla-bot bot commented Jul 24, 2025

The following people have not signed the Contributors License Agreement (CLA):

Read the CLA in the link above and sign it by clicking the link below:

You will receive a confirmation as soon as your signature is captured.

@github-actions github-actions bot added the bug Something isn't working label Jul 24, 2025
@hui-zhou-a hui-zhou-a linked an issue Jul 24, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.22%. Comparing base (ab0710a) to head (21f3c6d).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6461      +/-   ##
==========================================
- Coverage   82.29%   80.22%   -2.07%     
==========================================
  Files         231      231              
  Lines       74167    74170       +3     
==========================================
- Hits        61036    59506    -1530     
- Misses      13131    14664    +1533     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys previously approved these changes Aug 5, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il this fixes the skip we had to do, could you remove it ?

@hui-zhou-a
Copy link
Contributor Author

Il this fixes the skip we had to do, could you remove it ?

All fixed on pyedb side, but I am blocked by 25.2 which is not installed on pyedb test VM

@hui-zhou-a hui-zhou-a closed this Aug 19, 2025
@hui-zhou-a hui-zhou-a deleted the fix-via-design branch September 8, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in ViaDesígn Extension
3 participants