Skip to content

Conversation

anur7
Copy link
Contributor

@anur7 anur7 commented Aug 26, 2025

Description

This PR allows to correctly plot flux lines in Maxwell.

Issue linked

Issue #6573

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@anur7 anur7 self-assigned this Aug 26, 2025
@anur7 anur7 requested a review from a team as a code owner August 26, 2025 13:56
@anur7 anur7 added the enhancement New features or code improvements label Aug 26, 2025
@anur7 anur7 linked an issue Aug 26, 2025 that may be closed by this pull request
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.46%. Comparing base (6e14558) to head (402407d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6575      +/-   ##
==========================================
- Coverage   81.98%   76.46%   -5.53%     
==========================================
  Files         243      243              
  Lines       76279    76281       +2     
==========================================
- Hits        62540    58327    -4213     
- Misses      13739    17954    +4215     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys
Copy link
Member

@anur7 You missed adding a unit test

@anur7 anur7 added the testing Anything related to testing label Sep 3, 2025
@Samuelopez-ansys
Copy link
Member

I will change it to draft until it is not ready, Please test it locally first

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft September 4, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flux lines plot in Maxwell
4 participants