-
Notifications
You must be signed in to change notification settings - Fork 195
FEAT: waveport object advanced config #6595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6595 +/- ##
===========================================
- Coverage 82.34% 26.68% -55.67%
===========================================
Files 242 242
Lines 76995 77361 +366
===========================================
- Hits 63401 20642 -42759
- Misses 13594 56719 +43125 🚀 New features to boost your workflow:
|
…nsys/pyaedt into feat/waveport_object_alignment
…nsys/pyaedt into feat/waveport_object_alignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still lots of work to do on this.
Next week I will review it, thank you @eblanco-ansys for this great contribution |
The unit test now creates only one box for the waveguide, but it creates multiple port instances on the same face which would lead to an invalid project. It would be good to
|
@eblanco-ansys : Actually it would be good to raise an exception if trying to assign a port to a face where a port has already been assigned ;) |
Description
Added WavePortObject class to handle waveport advanced configuration in HFSS
Issue linked
Checklist