FEAT: add-Bachmann-Bundle #1085
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
PipKat
reviewed
Apr 30, 2025
| try: | ||
| right_atrium_epi = model.mesh.get_surface(model.right_atrium.epicardium.id) | ||
| except AttributeError: | ||
| LOGGER.error("Cannot find left atrium to create Bachmann bundle") |
There was a problem hiding this comment.
Suggested change
| LOGGER.error("Cannot find left atrium to create Bachmann bundle") | |
| LOGGER.error("Cannot find left atrium to create Bachmann bundle.") |
Should have concluding punctuation in messages.
PipKat
reviewed
Apr 30, 2025
| try: | ||
| left_atrium_epi = model.mesh.get_surface(model.left_atrium.epicardium.id) | ||
| except AttributeError: | ||
| LOGGER.error("Cannot find left atrium to create Bachmann bundle") |
There was a problem hiding this comment.
Suggested change
| LOGGER.error("Cannot find left atrium to create Bachmann bundle") | |
| LOGGER.error("Cannot find left atrium to create Bachmann bundle.") |
PipKat
reviewed
Apr 30, 2025
| bachmann_start = HeartModelUtils.define_bachman_bundle_start_node(model=model) | ||
| bachmann_end = HeartModelUtils.define_bachman_bundle_end_node(model=model) | ||
|
|
||
| # compute bachmann bundle without including it in model due to LS-DYNA bug in R16 |
There was a problem hiding this comment.
Suggested change
| # compute bachmann bundle without including it in model due to LS-DYNA bug in R16 | |
| # compute Bachmann bundle without including it in model due to LS-DYNA bug in R16 |
PipKat
reviewed
Apr 30, 2025
| assert np.allclose(ba_end.xyz, np.array([-48.38608303, 109.46168253, 424.58923502])) | ||
| assert ba_end.node_id == 108609 | ||
|
|
||
|
|
||
|
|
||
| def test_create_conductionbeams_on_surface(): | ||
| """Test conductionbeams can be initialized correctly on a surface.""" |
There was a problem hiding this comment.
Suggested change
| """Test conductionbeams can be initialized correctly on a surface.""" | |
| """Test conduction beams can be initialized correctly on a surface.""" |
Brief descriptions should generally not have code entities. Was "conductionbeams" the name of the test? Maybe reword to "Initialize test of conduction beams on a surface." Is the "correctly" necessary? Would anything ever be initialized incorrectly on a surface?
PipKat
approved these changes
Apr 30, 2025
PipKat
reviewed
May 8, 2025
| @@ -177,7 +178,7 @@ def define_his_bundle_bifurcation_node( | |||
| if target_coord is None: | |||
| av_coord = LandMarks.AV_NODE.xyz | |||
| if av_coord is None: | |||
| LOGGER.error("AV node need to be defined before.") | |||
| LOGGER.error("AV node needs to be defined before.") | |||
There was a problem hiding this comment.
Suggested change
| LOGGER.error("AV node needs to be defined before.") | |
| LOGGER.error("AV node must be defined before.") |
Must be defined before what?
PipKat
reviewed
May 8, 2025
| @@ -243,7 +244,7 @@ def define_his_bundle_end_node( | |||
| # find n-th closest point to bifurcation | |||
| bifurcation_coord = LandMarks.HIS_BIF_NODE.xyz | |||
| if bifurcation_coord is None: | |||
| LOGGER.error("AV node need to be defined before.") | |||
| LOGGER.error("AV node needs to be defined before.") | |||
There was a problem hiding this comment.
Suggested change
| LOGGER.error("AV node needs to be defined before.") | |
| LOGGER.error("AV node must be defined before.") |
Must be defind before what?
PipKat
reviewed
May 8, 2025
| if target_coord is None: | ||
| sa_coord = LandMarks.SA_NODE.xyz | ||
| if sa_coord is None: | ||
| LOGGER.error("SA node needs to be defined before.") |
There was a problem hiding this comment.
Suggested change
| LOGGER.error("SA node needs to be defined before.") | |
| LOGGER.error("SA node must be defined before.") |
Must be defind before what?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.