feat: update conductionpath #1147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
PipKat
reviewed
Aug 11, 2025
| Returns | ||
| ------- | ||
| ConductionPath | None | ||
| The updated conduction path if successful, None otherwise. |
There was a problem hiding this comment.
Suggested change
| The updated conduction path if successful, None otherwise. | |
| Updated conduction path if successful, None otherwise. |
We omit a leading article (An, A, The) in brief descriptions so the first word is an important one.
PipKat
reviewed
Aug 11, 2025
| segment = [] | ||
| for i, j in zip(ids[0:-1], ids[1:]): | ||
| for tri in triangles: | ||
| if i in tri and j in tri: | ||
| segment.append(tri) | ||
| break | ||
| break # keep only one triangle per line is enough |
There was a problem hiding this comment.
Suggested change
| break # keep only one triangle per line is enough | |
| break # keeping only one triangle per line is enough |
PipKat
reviewed
Aug 11, 2025
| ) | ||
| return path, surf | ||
|
|
||
| # keep global point ids as a necessary property for the surface mesh |
There was a problem hiding this comment.
Suggested change
| # keep global point ids as a necessary property for the surface mesh | |
| # keep global point IDs as a necessary property for the surface mesh |
PipKat
reviewed
Aug 11, 2025
| assert np.allclose(cp.mesh.points[0], np.array([0, 2, 0])) | ||
| assert np.allclose(cp.mesh.points[1], np.array([0.6, 0.6, 0])) | ||
|
|
||
|
|
||
| def test_create_path_on_surface_center(): | ||
| """Test conductionbeams can be initialized correctly on a pyvista sphere with 3 keypoints.""" |
There was a problem hiding this comment.
Suggested change
| """Test conductionbeams can be initialized correctly on a pyvista sphere with 3 keypoints.""" | |
| """Test that conduction beams can be initialized correctly on a PyVista sphere with three keypoints.""" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the ability to update coordinates of conductionpath by providing deformed relying surface.
This permits to generate conductio sytem before running zeropressure.