Skip to content

Experimental - remove _result_properties #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

rafacanton
Copy link
Contributor

No description provided.

@rafacanton rafacanton changed the title Rcanton/remove result props Experimental - remove _result_properties Jun 13, 2025
@rafacanton rafacanton marked this pull request as draft June 13, 2025 07:44
Copy link
Contributor

github-actions bot commented Jun 13, 2025

Some tests with 'continue-on-error: true' have failed:

  • PyDPF-Post docstring tests on windows-latest

  • PyDPF-Post API tests on windows-latest

  • PyDPF-Post docstring tests on ubuntu-latest

  • PyDPF-Post API tests on ubuntu-latest

    Created by continue-on-error-comment

Copy link

codecov bot commented Jun 13, 2025

❌ 155 Tests Failed:

Tests completed Failed Passed Skipped
6822 155 6667 178
View the top 3 failed test(s) by shortest run time
tests.test_plotter::test_field_elemental_nodal_plot_simple
Stack Traces | 0.047s run time
simple_bar = '.../downloaded_examples/result_files/ASimpleBar.rst'

    @pytest.mark.skipif(not HAS_PYVISTA, reason="Please install pyvista")
    def test_field_elemental_nodal_plot_simple(simple_bar):
        model = Model(simple_bar)
>       stress = model.results.element_nodal_forces()
E       AttributeError: 'CommonResults' object has no attribute 'element_nodal_forces'

tests/test_plotter.py:239: AttributeError
tests.test_operatorshelper::test_nodal_averaging
Stack Traces | 0.049s run time
simple_bar = '.../downloaded_examples/result_files/ASimpleBar.rst'

    def test_nodal_averaging(simple_bar):
        model = dpf.core.Model(simple_bar)
>       evol = model.results.element_nodal_forces()
E       AttributeError: 'CommonResults' object has no attribute 'element_nodal_forces'

tests/test_operatorshelper.py:80: AttributeError
tests.test_plotter::test_field_elemental_nodal_plot_scoped
Stack Traces | 0.05s run time
simple_bar = '.../downloaded_examples/result_files/ASimpleBar.rst'

    @pytest.mark.skipif(not HAS_PYVISTA, reason="Please install pyvista")
    def test_field_elemental_nodal_plot_scoped(simple_bar):
        model = Model(simple_bar)
        mesh_scoping = dpf.core.mesh_scoping_factory.elemental_scoping(
            element_ids=list(range(1501, 3001))
        )
>       stress = model.results.element_nodal_forces.on_mesh_scoping(mesh_scoping)
E       AttributeError: 'CommonResults' object has no attribute 'element_nodal_forces'

tests/test_plotter.py:251: AttributeError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@rafacanton rafacanton closed this Jun 13, 2025
@rafacanton rafacanton deleted the rcanton/remove_result_props branch June 13, 2025 08:20
@PProfizi PProfizi restored the rcanton/remove_result_props branch August 5, 2025 15:08
@PProfizi PProfizi self-assigned this Aug 5, 2025
@PProfizi PProfizi reopened this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove _result_properties dict and instead just rely on ResultInfo
2 participants