build: Update release CI to use trusted publishers. #4332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
prmukherj
requested review from
mkundu1,
seanpearsonuk and
hpohekar
as code owners
RobPasMue
requested changes
Aug 11, 2025
Comment on lines
+651
to
+655
| uses: pypa/[email protected] | ||
| with: | ||
| packages-dir: dist | ||
| repository-url: https://pkgs.dev.azure.com/pyansys/_packaging/pyansys/pypi/upload | ||
| skip-existing: true |
There was a problem hiding this comment.
Suggested change
| uses: pypa/[email protected] | |
| with: | |
| packages-dir: dist | |
| repository-url: https://pkgs.dev.azure.com/pyansys/_packaging/pyansys/pypi/upload | |
| skip-existing: true | |
| run: | | |
| pip install twine | |
| python -m twine upload --skip-existing ./**/*.whl | |
| python -m twine upload --skip-existing ./**/*.tar.gz |
The private PyPI needs to use the token approach
| with: | ||
| packages-dir: dist | ||
| repository-url: https://pkgs.dev.azure.com/pyansys/_packaging/pyansys/pypi/upload | ||
| skip-existing: true | ||
| env: | ||
| TWINE_USERNAME: PAT | ||
| TWINE_PASSWORD: ${{ secrets.PYANSYS_PYPI_PRIVATE_PAT }} |
There was a problem hiding this comment.
Suggested change
| TWINE_PASSWORD: ${{ secrets.PYANSYS_PYPI_PRIVATE_PAT }} | |
| TWINE_PASSWORD: ${{ secrets.PYANSYS_PYPI_PRIVATE_PAT }} | |
| TWINE_REPOSITORY_URL: https://pkgs.dev.azure.com/pyansys/_packaging/pyansys/pypi/upload |
Comment on lines
+660
to
668
| - name: Upload to Public PyPi using trusted publisher | ||
| uses: pypa/[email protected] | ||
| with: | ||
| packages-dir: dist | ||
| print-hash: true | ||
| skip-existing: false | ||
| env: | ||
| TWINE_USERNAME: __token__ | ||
| TWINE_PASSWORD: ${{ secrets.ANSYS_FLUENT_CORE_PYPI_TOKEN }} |
There was a problem hiding this comment.
Suggested change
| - name: Upload to Public PyPi using trusted publisher | |
| uses: pypa/[email protected] | |
| with: | |
| packages-dir: dist | |
| print-hash: true | |
| skip-existing: false | |
| env: | |
| TWINE_USERNAME: __token__ | |
| TWINE_PASSWORD: ${{ secrets.ANSYS_FLUENT_CORE_PYPI_TOKEN }} | |
| - name: "Download the library artifacts from build-library step" | |
| uses: actions/[email protected] | |
| with: | |
| name: ${{ env.PACKAGE_NAME }}-artifacts | |
| path: ${{ env.PACKAGE_NAME }}-artifacts | |
| - name: "Upload artifacts to PyPI using trusted publisher" | |
| uses: pypa/[email protected] | |
| with: | |
| repository-url: "https://upload.pypi.org/legacy/" | |
| print-hash: true | |
| packages-dir: ${{ env.PACKAGE_NAME }}-artifacts | |
| skip-existing: false |
| @@ -668,4 +673,3 @@ jobs: | |||
| files: | | |||
| ./**/*.whl | |||
| ./**/*.tar.gz | |||
There was a problem hiding this comment.
Suggested change
| ./**/*.tar.gz | |
| ./**/*.tar.gz | |
| ./**/*-wheelhouse-*.zip |
Wheelhouse is still needed in GitHub release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RobPasMue, @MaxJPRey could you please look if it conforms with the standards?
Thank you.