Skip to content

Clean up logging #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Clean up logging #255

wants to merge 32 commits into from

Conversation

nezgrath
Copy link
Collaborator

@nezgrath nezgrath commented Aug 5, 2025

Pull Request Template

Description

Please provide a brief description of the changes in this pull request.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have tested these changes locally and verified that they work as intended.
  • I have updated any documentation as needed to reflect these changes (if appropriate)
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.
  • Unit tests have been added (if appropriate)
  • Test-cases have been added (if appropriate)
  • Testing instructions have been added (if appropriate)

@nezgrath nezgrath requested a review from ojkoenig as a code owner August 5, 2025 11:34
@nezgrath nezgrath requested a review from FedericoNegri as a code owner August 5, 2025 11:34
@github-actions github-actions bot added the maintenance Package and maintenance related label Aug 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.49%. Comparing base (7dc6add) to head (d11013e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/hps/data_transfer/client/binary.py 71.11% 13 Missing ⚠️
src/ansys/hps/data_transfer/client/client.py 69.76% 13 Missing ⚠️
src/ansys/hps/data_transfer/client/api/handler.py 90.76% 6 Missing ⚠️
src/ansys/hps/data_transfer/client/api/api.py 80.00% 4 Missing ⚠️
...rc/ansys/hps/data_transfer/client/api/async_api.py 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   84.84%   83.49%   -1.35%     
==========================================
  Files          19       20       +1     
  Lines        1300     1412     +112     
==========================================
+ Hits         1103     1179      +76     
- Misses        197      233      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Aug 5, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Aug 6, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants