feat: Add wrinqr access to mapdl_inprocess #4177
Conversation
|
CLA Check Failed: Commit Author Verification Unsuccessful One or more commits in this pull request contain missing or invalid author information. This issue may arise due to:
Please update the commit author details and push the updated commit to proceed with the CLA verification. |
valallansys
changed the title
valallansys
changed the title
valallansys
force-pushed
the
feat/add_wrinqr_to_inprocess
branch
from
8c8b298 to
414164d
Compare
|
|
||
| return self._in_process_backend.run_command(command, verbose, mute).strip() | ||
|
|
||
| def wrinqr(self, key: int) -> int: |
There was a problem hiding this comment.
can you create a fallback for older versions of mapdl? Someone might create a virtual environment with mapdl version 252 that pulls the latest pymapdl version.
There was a problem hiding this comment.
I just pushed a solution but self.version was calling the wrong wrinqr which ended up in a recusrion error. I overloaded version to fix that. Tell me what you think about it
|
@Revathyvenugopal162 @jorgepiloto CLA is failing again |
|
@valallansys ping me when this is ready to review and all the comments have been addressed. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
valallansys
force-pushed
the
feat/add_wrinqr_to_inprocess
branch
from
7c106ca to
206b7c8
Compare
The issue was caused by the username set on the machine. Even after fixing that and force-pushing, the information wasn’t removed. However, the CLA bot passes on new PRs. For example: https://github.com/ansys/pymapdl/pull/4178/checks?check_run_id=48302847975. So, you can either merge this PR or open a new one. Please note that the CLA might not pass on this PR because it contains that orphan commit, and the PR owner’s data is also orphaned since their first commit was orphaned as well
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4177 +/- ##
==========================================
- Coverage 91.49% 87.68% -3.81%
==========================================
Files 193 193
Lines 15730 15730
==========================================
- Hits 14392 13793 -599
- Misses 1338 1937 +599 🚀 New features to boost your workflow:
|
|
Closing this PR because of an issue with my username. Moving to #4179 |
5 participants
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)