Skip to content

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 22, 2025

Description

Refactor picking tests

Issue linked

NA

Checklist

@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 12:24
@germa89 germa89 requested a review from a team as a code owner August 22, 2025 12:24
@germa89 germa89 changed the title fix: improve debug function for keypoint and area selection in tests tests: improving picking tests Aug 22, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors debug functions in picking tests to improve reliability and maintainability by standardizing coordinate calculations and making assertions more flexible.

  • Renamed debug functions from debug_orders to improved_debug_orders
  • Replaced hardcoded window sizes and coordinates with predictable normalized coordinates
  • Updated test assertions to be more flexible and geometry-aware
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the enhancement Improve any current implemented feature label Aug 22, 2025
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.49%. Comparing base (1268ded) to head (8855429).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4191      +/-   ##
==========================================
- Coverage   91.39%   86.49%   -4.91%     
==========================================
  Files         193      193              
  Lines       15731    15731              
==========================================
- Hits        14378    13607     -771     
- Misses       1353     2124     +771     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 changed the title tests: improving picking tests test: improving picking tests Aug 25, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Aug 29, 2025

@AlejandroFernandezLuces do you support picking operations in the ansys-tools-visualization ??

@AlejandroFernandezLuces
Copy link
Contributor

Yes, it is supported. Maybe something broke, I'll check on the viz tool side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants