-
Notifications
You must be signed in to change notification settings - Fork 139
test: improving picking tests #4191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors debug functions in picking tests to improve reliability and maintainability by standardizing coordinate calculations and making assertions more flexible.
- Renamed debug functions from
debug_orders
toimproved_debug_orders
- Replaced hardcoded window sizes and coordinates with predictable normalized coordinates
- Updated test assertions to be more flexible and geometry-aware
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4191 +/- ##
==========================================
- Coverage 91.39% 86.49% -4.91%
==========================================
Files 193 193
Lines 15731 15731
==========================================
- Hits 14378 13607 -771
- Misses 1353 2124 +771 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <[email protected]>
@AlejandroFernandezLuces do you support picking operations in the |
Yes, it is supported. Maybe something broke, I'll check on the viz tool side. |
Description
Refactor picking tests
Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)