Skip to content

[Go] Use strings.Builder instead of string concat #4820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Go] Use strings.Builder instead of string concat #4820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions runtime/Go/antlr/v4/common_token_stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package antlr

import (
"strconv"
"strings"
)

// CommonTokenStream is an implementation of TokenStream that loads tokens from
Expand Down Expand Up @@ -351,7 +352,7 @@ func (c *CommonTokenStream) GetTextFromInterval(interval Interval) string {
stop = len(c.tokens) - 1
}

s := ""
var sb strings.Builder

for i := start; i < stop+1; i++ {
t := c.tokens[i]
Expand All @@ -360,10 +361,10 @@ func (c *CommonTokenStream) GetTextFromInterval(interval Interval) string {
break
}

s += t.GetText()
sb.WriteString(t.GetText())
}

return s
return sb.String()
}

// Fill gets all tokens from the lexer until EOF.
Expand Down Expand Up @@ -447,4 +448,4 @@ func (c *CommonTokenStream) getNumberOfOnChannelTokens() int {
}

return n
}
}
Loading