-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: The events array after splitting may contain empty strings, w… #12155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…hich can cause subsequent messages to be skipped.
please add test cases too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix failed lint CI
Hi @vislee, is there time to continue with this PR? |
I've pushed the fix failed lint CI.
|
Hi @vislee, any updates? |
I'll convert this PR to draft first, if the changes are done please request review again. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
Description
The
ctx.ai_token_usage
may not get the correct value.The
events
array after splitting may contain empty strings, which can cause subsequentevent
to be skipped.Which issue(s) this PR fixes:
Fixes #
Checklist