Add conditional deletes #427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankrgyl
force-pushed
the
conditional-delete
branch
from
082ada2 to
a3e2784
Compare
|
Thank you for this, I think this needs some tests. I only see tests for InMemory |
|
Yep very happy to fill in more tests. Do you just generally run them against your own object storage accounts? |
|
As far as I know, aws only support delete with if match on s3 express. |
Ah yes that is correct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #298
Rationale for this change
It's useful to have conditional deletes while implementing concurrent primitives on object stores, like distributed locks.
What changes are included in this PR?
Mirror the conditional put implementation to support conditional deletes
Are there any user-facing changes?
Yes a new
delete_optsmethod that accepts deletion opts.