Fix for URI generation issue #434 #435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When issuing list requests using the AWS module, we noticed that list objects requests were failing due to a strange URI. We saw the generated URI was `http://server/bucket?&list-type=2&prefix=foo/` but it should be `http://server/bucket?list-type=2&prefix=foo/` i.e. the query string should not start with an ampersand before the list-type parameter.
tustvold
reviewed
Jul 10, 2025
| let mut encoder = form_urlencoded::Serializer::for_suffix(&mut out, start_position); | ||
| // Build the query string, preserving any existing query parameters. | ||
| // This prevents malformed URIs like "/bucket?&list-type=2" when the URI | ||
| // already contains query parameters. |
There was a problem hiding this comment.
Why do we need to handle this case, we didn't before - we solely used the path?
Was this AI generated or something?
There was a problem hiding this comment.
Not sure if it's really a bug in the library. A query string that starts with an ampersand works fine in php($_GET["var"]) and python3 urllib parse_qs. I am also unable to find any RFC or protocol specification that outlines that a query string should not/cannot begin with an ampersand.
|
Converting to draft as not waiting on review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When issuing list requests using the AWS module, we noticed that list objects requests were failing due to a strange URI. We saw the generated URI was
http://server/bucket?&list-type=2&prefix=foo/but it should be
http://server/bucket?list-type=2&prefix=foo/i.e. the query string should not start with an ampersand before the list-type parameter.
Which issue does this PR close?
Closes #434
Rationale for this change
Fixes URI query parameter building to be more standard.
What changes are included in this PR?
One change to URI building.
Are there any user-facing changes?
None.